From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ltrace: disable elfutils unwinding when libunwind is used
Date: Sun, 7 Dec 2014 22:00:14 +0100 [thread overview]
Message-ID: <20141207220014.1d0dede0@free-electrons.com> (raw)
In-Reply-To: <8b0ae63676267c7fb215344ddb2ef959eaaf165d.1417763393.git.baruch@tkos.co.il>
Dear Baruch Siach,
On Fri, 5 Dec 2014 09:09:53 +0200, Baruch Siach wrote:
> ltrace can't use both.
>
> Fixes:
> http://autobuild.buildroot.net/results/a3c/a3c1647578cdeda3aaf672084a9a893f06dbad26/
> http://autobuild.buildroot.net/results/fdb/fdb7e760faeda77b263a6dac3e322a25b53e67ff/
> http://autobuild.buildroot.net/results/70a/70a0614ca7baf6a46898834a87cd46865f6e3385/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/ltrace/ltrace.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/ltrace/ltrace.mk b/package/ltrace/ltrace.mk
> index 5c9549f4019b..61e0fb7d57be 100644
> --- a/package/ltrace/ltrace.mk
> +++ b/package/ltrace/ltrace.mk
> @@ -21,7 +21,7 @@ LTRACE_POST_PATCH_HOOKS += LTRACE_CREATE_CONFIG_M4
> # We don't normally do so for uClibc and we can't know if it's external
> ifeq ($(BR2_PACKAGE_LIBUNWIND),y)
> ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),)
> -LTRACE_CONF_OPTS += --with-libunwind=yes
> +LTRACE_CONF_OPTS += --with-libunwind=yes --with-elfutils=no
While I agree with the analysis, I don't agree with the proposed fix:
ltrace selects elfutils unconditionally (see Config.in), so it is quite
weird to see ltrace not using it in the end. So I believe the Config.in
*and* ltrace dependencies should be updated to reflect the fact that
either unwind or elfutils can be used.
Could you work on an updated patch?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-12-07 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 7:09 [Buildroot] [PATCH] ltrace: disable elfutils unwinding when libunwind is used Baruch Siach
2014-12-07 21:00 ` Thomas Petazzoni [this message]
2014-12-09 6:02 ` Baruch Siach
2014-12-09 7:51 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141207220014.1d0dede0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.