From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 1/6] mfd: rtsx: add func to split u32 into register Date: Mon, 8 Dec 2014 09:57:46 +0000 Message-ID: <20141208095746.GG3951@x1> References: <17ba65f4bdf4707bdf038e407ecf5dc012bca281.1417758564.git.micky_ching@realsil.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <17ba65f4bdf4707bdf038e407ecf5dc012bca281.1417758564.git.micky_ching@realsil.com.cn> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: micky_ching@realsil.com.cn Cc: ulf.hansson@linaro.org, sameo@linux.intel.com, gregkh@linuxfoundation.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, chris@printf.net, wei_wang@realsil.com.cn, rogerable@realtek.com, devel@linuxdriverproject.org, dan.carpenter@oracle.com List-Id: linux-mmc@vger.kernel.org T24gRnJpLCAwNSBEZWMgMjAxNCwgbWlja3lfY2hpbmdAcmVhbHNpbC5jb20uY24gd3JvdGU6Cj4g RnJvbTogTWlja3kgQ2hpbmcgPG1pY2t5X2NoaW5nQHJlYWxzaWwuY29tLmNuPgo+IAo+IEFkZCBo ZWxwZXIgZnVuY3Rpb24gdG8gd3JpdGUgdTMyIHRvIHJlZ2lzdGVycywgaWYgd2Ugd2FudCB0byBw dXQgdTMyCj4gdmFsdWUgdG8gNCBjb250aW51b3VzIHJlZ2lzdGVyLCB0aGlzIGNhbiBoZWxwIHVz IHJlZHVjZSB0ZWRpb3VzIHdvcmsuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWlja3kgQ2hpbmcgPG1p Y2t5X2NoaW5nQHJlYWxzaWwuY29tLmNuPgo+IEFja2VkLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25l c0BsaW5hcm8ub3JnPgo+IC0tLQo+ICBpbmNsdWRlL2xpbnV4L21mZC9ydHN4X3BjaS5oIHwgOSAr KysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKQoKQXBwbGllZCwgdGhh bmtzLgoKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9tZmQvcnRzeF9wY2kuaCBiL2luY2x1 ZGUvbGludXgvbWZkL3J0c3hfcGNpLmgKPiBpbmRleCA3NDM0NmQ1Li45MjM0NDQ5IDEwMDY0NAo+ IC0tLSBhL2luY2x1ZGUvbGludXgvbWZkL3J0c3hfcGNpLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4 L21mZC9ydHN4X3BjaS5oCj4gQEAgLTU1OCw2ICs1NTgsNyBAQAo+ICAjZGVmaW5lIFNEX1NBTVBM RV9QT0lOVF9DVEwJCTB4RkRBNwo+ICAjZGVmaW5lIFNEX1BVU0hfUE9JTlRfQ1RMCQkweEZEQTgK PiAgI2RlZmluZSBTRF9DTUQwCQkJCTB4RkRBOQo+ICsjZGVmaW5lICAgU0RfQ01EX1NUQVJUCQkJ MHg0MAo+ICAjZGVmaW5lIFNEX0NNRDEJCQkJMHhGREFBCj4gICNkZWZpbmUgU0RfQ01EMgkJCQkw eEZEQUIKPiAgI2RlZmluZSBTRF9DTUQzCQkJCTB4RkRBQwo+IEBAIC05NjcsNCArOTY4LDEyIEBA IHN0YXRpYyBpbmxpbmUgdTggKnJ0c3hfcGNpX2dldF9jbWRfZGF0YShzdHJ1Y3QgcnRzeF9wY3Ig KnBjcikKPiAgCXJldHVybiAodTggKikocGNyLT5ob3N0X2NtZHNfcHRyKTsKPiAgfQo+ICAKPiAr c3RhdGljIGlubGluZSB2b2lkIHJ0c3hfcGNpX3dyaXRlX2JlMzIoc3RydWN0IHJ0c3hfcGNyICpw Y3IsIHUxNiByZWcsIHUzMiB2YWwpCj4gK3sKPiArCXJ0c3hfcGNpX2FkZF9jbWQocGNyLCBXUklU RV9SRUdfQ01ELCByZWcsICAgICAweEZGLCB2YWwgPj4gMjQpOwo+ICsJcnRzeF9wY2lfYWRkX2Nt ZChwY3IsIFdSSVRFX1JFR19DTUQsIHJlZyArIDEsIDB4RkYsIHZhbCA+PiAxNik7Cj4gKwlydHN4 X3BjaV9hZGRfY21kKHBjciwgV1JJVEVfUkVHX0NNRCwgcmVnICsgMiwgMHhGRiwgdmFsID4+IDgp Owo+ICsJcnRzeF9wY2lfYWRkX2NtZChwY3IsIFdSSVRFX1JFR19DTUQsIHJlZyArIDMsIDB4RkYs IHZhbCk7Cj4gK30KPiArCj4gICNlbmRpZgoKLS0gCkxlZSBKb25lcwpMaW5hcm8gU1RNaWNyb2Vs ZWN0cm9uaWNzIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNv ZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBC bG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmVs IG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJk ZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaXZlcmRldi1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754877AbaLHJ5y (ORCPT ); Mon, 8 Dec 2014 04:57:54 -0500 Received: from mail-qa0-f47.google.com ([209.85.216.47]:44295 "EHLO mail-qa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754812AbaLHJ5w (ORCPT ); Mon, 8 Dec 2014 04:57:52 -0500 Date: Mon, 8 Dec 2014 09:57:46 +0000 From: Lee Jones To: micky_ching@realsil.com.cn Cc: sameo@linux.intel.com, chris@printf.net, ulf.hansson@linaro.org, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, gregkh@linuxfoundation.org, dan.carpenter@oracle.com, rogerable@realtek.com, wei_wang@realsil.com.cn Subject: Re: [PATCH v4 1/6] mfd: rtsx: add func to split u32 into register Message-ID: <20141208095746.GG3951@x1> References: <17ba65f4bdf4707bdf038e407ecf5dc012bca281.1417758564.git.micky_ching@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <17ba65f4bdf4707bdf038e407ecf5dc012bca281.1417758564.git.micky_ching@realsil.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 Dec 2014, micky_ching@realsil.com.cn wrote: > From: Micky Ching > > Add helper function to write u32 to registers, if we want to put u32 > value to 4 continuous register, this can help us reduce tedious work. > > Signed-off-by: Micky Ching > Acked-by: Lee Jones > --- > include/linux/mfd/rtsx_pci.h | 9 +++++++++ > 1 file changed, 9 insertions(+) Applied, thanks. > diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h > index 74346d5..9234449 100644 > --- a/include/linux/mfd/rtsx_pci.h > +++ b/include/linux/mfd/rtsx_pci.h > @@ -558,6 +558,7 @@ > #define SD_SAMPLE_POINT_CTL 0xFDA7 > #define SD_PUSH_POINT_CTL 0xFDA8 > #define SD_CMD0 0xFDA9 > +#define SD_CMD_START 0x40 > #define SD_CMD1 0xFDAA > #define SD_CMD2 0xFDAB > #define SD_CMD3 0xFDAC > @@ -967,4 +968,12 @@ static inline u8 *rtsx_pci_get_cmd_data(struct rtsx_pcr *pcr) > return (u8 *)(pcr->host_cmds_ptr); > } > > +static inline void rtsx_pci_write_be32(struct rtsx_pcr *pcr, u16 reg, u32 val) > +{ > + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg, 0xFF, val >> 24); > + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 1, 0xFF, val >> 16); > + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 2, 0xFF, val >> 8); > + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 3, 0xFF, val); > +} > + > #endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog