From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxyyp-0007dp-89 for qemu-devel@nongnu.org; Mon, 08 Dec 2014 09:08:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xxyyf-0004ah-Cb for qemu-devel@nongnu.org; Mon, 08 Dec 2014 09:08:03 -0500 Received: from mail-pd0-x236.google.com ([2607:f8b0:400e:c02::236]:57329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxyyf-0004aT-55 for qemu-devel@nongnu.org; Mon, 08 Dec 2014 09:07:53 -0500 Received: by mail-pd0-f182.google.com with SMTP id p10so827712pdj.41 for ; Mon, 08 Dec 2014 06:07:52 -0800 (PST) Date: Mon, 8 Dec 2014 22:07:42 +0800 From: Jun Li Message-ID: <20141208140741.GC2836@localhost.localdomain> References: <1415170983-12981-1-git-send-email-junmuzi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1415170983-12981-1-git-send-email-junmuzi@gmail.com> Subject: Re: [Qemu-devel] [PATCH v3] qdev: Avoid type assertion in qdev_build_hotpluggable_device_list() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.crosthwaite@xilinx.com, famz@redhat.com, mst@redhat.com, juli@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, afaerber@suse.de Ping, why does this patch has not been merged until now? Could anyone give some explanations? Thx. Regards, Jun Li On Wed, 11/05 15:03, Jun Li wrote: > Currently when *obj is not a TYPE_DEVICE, qemu will abort. This patch just > fixed it. When *obj is not a TYPE_DEVICE, just do not add it to hotpluggable > device list. > > This patch also fixed the following issue: > 1, boot qemu using cli: > $ /opt/qemu-git-arm/bin/qemu-system-x86_64 -monitor stdio -enable-kvm \ > -device virtio-scsi-pci,id=scsi0 > > 2, device_del scsi0 via hmp using tab key(first input device_del, then press > "Tab" key). > (qemu) device_del > > After step2, qemu will abort. > (qemu) device_del hw/core/qdev.c:930:qdev_build_hotpluggable_device_list: > Object 0x5555563a2460 is not an instance of type device > > Signed-off-by: Jun Li > Reviewed-by: Paolo Bonzini > --- > v3: > According to Andreas's suggestion, do some changes. As followings: > 1, change the Subject to more meaningful. > 2, use two "return 0" to return early avoid reindentation. And I have found in qcow2_grow_l1_table has also used two "return 0". So accept Andreas's suggestion. Thanks. > > v2: > This version just do a little changes for the commit message. > As following show: > In v1, > 1, boot qemu using cli: > virtio-scsi-pci,id=scsi0 -enable-kvm > > In v2, > 1, boot qemu using cli: > $ /opt/qemu-git-arm/bin/qemu-system-x86_64 -monitor stdio -enable-kvm \ > -device virtio-scsi-pci,id=scsi0 > --- > hw/core/qdev.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > index b3d5196..7db3e13 100644 > --- a/hw/core/qdev.c > +++ b/hw/core/qdev.c > @@ -927,7 +927,12 @@ void qdev_alias_all_properties(DeviceState *target, Object *source) > int qdev_build_hotpluggable_device_list(Object *obj, void *opaque) > { > GSList **list = opaque; > - DeviceState *dev = DEVICE(obj); > + DeviceState *dev = (DeviceState *)object_dynamic_cast(OBJECT(obj), > + "device"); > + > + if (dev == NULL) { > + return 0; > + } > > if (dev->realized && object_property_get_bool(obj, "hotpluggable", NULL)) { > *list = g_slist_append(*list, dev); > -- > 1.9.3 >