From: Cyril Hrubis <chrubis@suse.cz>
To: Alexey Kodanev <alexey.kodanev@oracle.com>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 2/2] device-drivers/cpufreq: add intel_pstate driver to boost test
Date: Mon, 8 Dec 2014 19:02:21 +0100 [thread overview]
Message-ID: <20141208180221.GA18182@rei> (raw)
In-Reply-To: <5485D893.4030403@oracle.com>
Hi!
> > Will simple access() suffice here or do we have to actually open the
> > file?
>
> We have to open it, it was changed from access to open in this commit:
>
> commit 0a91955ab91bf518ff56a44bb2969b0cb549a979
> Date: Wed May 7 17:03:33 2014 +0400
>
> device-drivers/acpi/ltp_acpi_cpufreq: fix checking for write permission
>
> If access(some_file, W_OK) is executed by root it will return
> success even
> if file has read-only permission. Use 'open' to test sysfs file for
> write
> permission.
>
> Doc updated as well:
>
> commit fb3da0a1f3a4f1b836e50033cb8acf7c6d0c5a05
> Date: Tue May 13 15:34:32 2014 +0400
>
> docs: add a paragraph about access() to Common Problems section
Ah, right, deja vu.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2014-12-08 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 17:20 [LTP] [PATCH 1/2] device-drivers/ltp_acpi_cpufreq: move it to cpufreq/cpufreq_boost Alexey Kodanev
2014-12-04 17:20 ` [LTP] [PATCH 2/2] device-drivers/cpufreq: add intel_pstate driver to boost test Alexey Kodanev
2014-12-08 11:42 ` Cyril Hrubis
[not found] ` <5485D893.4030403@oracle.com>
2014-12-08 18:02 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208180221.GA18182@rei \
--to=chrubis@suse.cz \
--cc=alexey.kodanev@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.