From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyI6a-0008QI-5M for qemu-devel@nongnu.org; Tue, 09 Dec 2014 05:33:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyI6U-0004IV-0r for qemu-devel@nongnu.org; Tue, 09 Dec 2014 05:33:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyI6T-0004IF-Qa for qemu-devel@nongnu.org; Tue, 09 Dec 2014 05:33:13 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB9AXCEv018640 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 9 Dec 2014 05:33:12 -0500 Date: Tue, 9 Dec 2014 12:33:09 +0200 From: "Michael S. Tsirkin" Message-ID: <20141209103309.GA3993@redhat.com> References: <1418054888-11310-1-git-send-email-imammedo@redhat.com> <1418054888-11310-2-git-send-email-imammedo@redhat.com> <20141208205705.GA30082@redhat.com> <20141209110537.63a06381@nial.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141209110537.63a06381@nial.usersys.redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/9] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, marcel.a@redhat.com On Tue, Dec 09, 2014 at 11:05:37AM +0100, Igor Mammedov wrote: > On Mon, 8 Dec 2014 22:57:05 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Dec 08, 2014 at 04:08:00PM +0000, Igor Mammedov wrote: > > > ACPI parser in XP considers PNP0A06 devices of CPU and > > > memory hotplug as duplicates. Adding unique _UID > > > to CPU hotplug device fixes BSOD. > > > > > > Signed-off-by: Igor Mammedov > > > > And let's add them for memory hotplug as well? > XP doesn't support it. > > Also, if we do stable branch release, we probably > > want to only do it for memory hotplug in a separate > > patch, right? > > This way users who don't enable memory hotplug > > are unaffected, reduces risk slightly. > Memory hotplug device already has _UID, so it doesn't need patching. > This patch just fixes BSOD if QEMU has been started with > hotplug enabled i.e. for example -m 2G,slots=2,maxmem=4G, > and prevents clashing between memory hotplug and > cpu hotplug devices on XP (i.e. XP specific quirk). > > I've tested it with XPsp3 and all later version upto WS2012R2. I see, I misunderstood. Thanks, I'll apply this one. > > > > > > --- > > > hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-hotplug.dsl > > > index 34aab5a..268d870 100644 > > > --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl > > > +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl > > > @@ -94,6 +94,7 @@ Scope(\_SB) { > > > > > > Device(CPU_HOTPLUG_RESOURCE_DEVICE) { > > > Name(_HID, EisaId("PNP0A06")) > > > + Name(_UID, "CPU hotplug resources") > > > > > > Name(_CRS, ResourceTemplate() { > > > IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_STATUS_LEN) > > > -- > > > 1.8.3.1