From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH for-xen-4.5 1/3] tools/hotplug: distclean
 target should remove files generated by configure
Date: Tue, 9 Dec 2014 10:32:57 -0500
Message-ID: <20141209153257.GA9585@laptop.dumpdata.com>
References: <1417533390-29035-1-git-send-email-daniel.kiper@oracle.com>
	<1417533390-29035-2-git-send-email-daniel.kiper@oracle.com>
	<1418135737.14361.71.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <konrad.wilk@oracle.com>) id 1XyMmj-0001Un-ND
	for xen-devel@lists.xenproject.org; Tue, 09 Dec 2014 15:33:09 +0000
Content-Disposition: inline
In-Reply-To: <1418135737.14361.71.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: keir@xen.org, andrew.cooper3@citrix.com, Daniel Kiper <daniel.kiper@oracle.com>, ian.jackson@eu.citrix.com, jbeulich@suse.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Tue, Dec 09, 2014 at 02:35:37PM +0000, Ian Campbell wrote:
> On Tue, 2014-12-02 at 16:16 +0100, Daniel Kiper wrote:
> 
> > +distclean:
> > +	rm -f Linux/init.d/sysconfig.xencommons Linux/init.d/xencommons NetBSD/rc.d/xencommons
> 
> Configure generates a boatload more things than this, see e.g. 
> 
> $ grep hotplug/ tools/configure.ac 
> 
> Perhaps the answer would be to recurse into tools/hotplug/* and refactor
> the existing XEN_SCRIPTS to have the generated stuff in XEN_SCRIPTS_GEN
> instead and XEN_SCRIPTS += $(XEN_SCRIPTS). The on distclean remove the
> XEN_SCRIPTS_GEN ones.
> 
> It's not ideal, but at least it puts the distclean logic in the same
> place as the logic to install the files, if not their generation, which
> at least increases the chance of someone adding it to the right place.

Daniel pointed to me that the two other patches that were committed
solve the problem of seeing those auto-generated files sticking (and
forcing one to use git checkout XYZ -f).

So this small patch can be ditched in favour of the more encompassing
design that you have sketched out.

Thank you!
> 
> Ian.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel