From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [v8][PATCH 02/17] introduce XEN_DOMCTL_set_rdm Date: Tue, 9 Dec 2014 11:36:37 -0500 Message-ID: <20141209163637.GB10129@laptop.dumpdata.com> References: <1417425875-9634-1-git-send-email-tiejun.chen@intel.com> <1417425875-9634-3-git-send-email-tiejun.chen@intel.com> <20141202193943.GC357@laptop.dumpdata.com> <548517F7.6040106@intel.com> <20141208155734.GE7745@laptop.dumpdata.com> <54864B1C.6020701@intel.com> <5486C204020000780004DF9A@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5486C204020000780004DF9A@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, yang.z.zhang@intel.com, Tiejun Chen List-Id: xen-devel@lists.xenproject.org On Tue, Dec 09, 2014 at 08:33:56AM +0000, Jan Beulich wrote: > >>> On 09.12.14 at 02:06, wrote: > >>>> Also how does this work with 32-bit dom0s? Is there a need to use the > >>>> compat layer? > >>> > >>> Are you saying in xsm case? Others? > >>> > >>> Actually this new DOMCTL is similar with XEN_DOMCTL_assign_device in some > >>> senses but I don't see such an issue you're pointing. > >> > >> I was thinking about the compat layer and making sure it works properly. > > > > Do we really need this consideration? I mean I referred to that existing > > XEN_DOMCTL_assign_device to implement this new DOMCTL, but looks there's > > nothing related to this point. > > > > Or could you make your thought clear to me with an exiting example? Then > > I can take a look at what exactly should be taken in my new DOMCTL since > > I'm a fresh man to work out this properly inside xen. > > I think Konrad got a little confused here - domctl-s intentionally are > structured so that they don't need a compat translation layer. Ah! Thank you for that reminder! > > Jan >