From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6
Date: Wed, 10 Dec 2014 08:46:17 +0100 [thread overview]
Message-ID: <20141210074617.GG13486@pengutronix.de> (raw)
In-Reply-To: <1418141616-29671-1-git-send-email-p.zabel@pengutronix.de>
Hello Philipp,
On Tue, Dec 09, 2014 at 05:13:35PM +0100, Philipp Zabel wrote:
> + /* on i.MX6Q, the USBMISC register space is clocked by the IPG clock */
> + if (data->ops != &imx6q_usbmisc_ops) {
> + data->clk = devm_clk_get(&pdev->dev, NULL);
I wonder if it was better/simpler to handle devm_clk_get returning
-ENOENT and assume this means there is no need for a clock in this case.
(I think devm_clk_get prints an error message in this case. That's ugly
when the error is handled just fine.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2014-12-10 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 16:13 [PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6 Philipp Zabel
2014-12-09 16:13 ` [PATCH 2/2] ARM: dts: imx6qdl: remove USBOH3 clock from usbmisc, it is clocked by IPG Philipp Zabel
2014-12-10 5:09 ` [PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6 Peter Chen
2014-12-10 10:26 ` Philipp Zabel
2014-12-10 7:46 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210074617.GG13486@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.