From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] ALSA: lola: NULL dereference on probe failure Date: Wed, 10 Dec 2014 16:06:46 +0300 Message-ID: <20141210130646.GA18593@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by alsa0.perex.cz (Postfix) with ESMTP id DFDC9260519 for ; Wed, 10 Dec 2014 14:07:06 +0100 (CET) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Jaroslav Kysela Cc: alsa-devel@alsa-project.org, Takashi Iwai , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Benoit Taine , Bjorn Helgaas List-Id: alsa-devel@alsa-project.org "card" is NULL if snd_card_new() fails. Signed-off-by: Dan Carpenter diff --git a/sound/pci/lola/lola.c b/sound/pci/lola/lola.c index a75c8dc..4cf4be5 100644 --- a/sound/pci/lola/lola.c +++ b/sound/pci/lola/lola.c @@ -719,7 +719,7 @@ static int lola_probe(struct pci_dev *pci, err = snd_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE, 0, &card); if (err < 0) { - dev_err(card->dev, "Error creating card!\n"); + dev_err(&pci->dev, "Error creating card!\n"); return err; } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 10 Dec 2014 13:06:46 +0000 Subject: [patch] ALSA: lola: NULL dereference on probe failure Message-Id: <20141210130646.GA18593@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jaroslav Kysela Cc: alsa-devel@alsa-project.org, Takashi Iwai , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Benoit Taine , Bjorn Helgaas "card" is NULL if snd_card_new() fails. Signed-off-by: Dan Carpenter diff --git a/sound/pci/lola/lola.c b/sound/pci/lola/lola.c index a75c8dc..4cf4be5 100644 --- a/sound/pci/lola/lola.c +++ b/sound/pci/lola/lola.c @@ -719,7 +719,7 @@ static int lola_probe(struct pci_dev *pci, err = snd_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE, 0, &card); if (err < 0) { - dev_err(card->dev, "Error creating card!\n"); + dev_err(&pci->dev, "Error creating card!\n"); return err; } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755658AbaLJNHT (ORCPT ); Wed, 10 Dec 2014 08:07:19 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:35997 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752193AbaLJNHR (ORCPT ); Wed, 10 Dec 2014 08:07:17 -0500 Date: Wed, 10 Dec 2014 16:06:46 +0300 From: Dan Carpenter To: Jaroslav Kysela Cc: Takashi Iwai , Benoit Taine , Bjorn Helgaas , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] ALSA: lola: NULL dereference on probe failure Message-ID: <20141210130646.GA18593@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "card" is NULL if snd_card_new() fails. Signed-off-by: Dan Carpenter diff --git a/sound/pci/lola/lola.c b/sound/pci/lola/lola.c index a75c8dc..4cf4be5 100644 --- a/sound/pci/lola/lola.c +++ b/sound/pci/lola/lola.c @@ -719,7 +719,7 @@ static int lola_probe(struct pci_dev *pci, err = snd_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE, 0, &card); if (err < 0) { - dev_err(card->dev, "Error creating card!\n"); + dev_err(&pci->dev, "Error creating card!\n"); return err; }