All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Anjana Sasindran <anjanasasindran123@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: rts5208: Removed the new typedefs
Date: Wed, 10 Dec 2014 09:20:03 -0500	[thread overview]
Message-ID: <20141210142003.GA15524@kroah.com> (raw)
In-Reply-To: <1418219656-2964-1-git-send-email-anjanasasindran123@gmail.com>

On Wed, Dec 10, 2014 at 07:24:16PM +0530, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning:
> 
> WARNING: do not add new typedefs
> 
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
> ---
>  drivers/staging/rts5208/rtsx_sys.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx_sys.h b/drivers/staging/rts5208/rtsx_sys.h
> index 0b6b4d4..f04d997 100644
> --- a/drivers/staging/rts5208/rtsx_sys.h
> +++ b/drivers/staging/rts5208/rtsx_sys.h
> @@ -28,7 +28,7 @@
>  #include "rtsx_chip.h"
>  #include "rtsx_card.h"
>  
> -typedef dma_addr_t ULONG_PTR;
> +dma_addr_t ULONG_PTR;
>  
>  static inline void rtsx_exclusive_enter_ss(struct rtsx_chip *chip)
>  {

Please learn how the C language works before attempting to contribute to
the Linux kernel.  You obviously didn't even test build this code, which
means you are trying to waste my time, a very rude thing to do to
someone else, don't you think?

*plonk*

      reply	other threads:[~2014-12-10 14:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10 13:54 [PATCH] staging: rts5208: Removed the new typedefs Anjana Sasindran
2014-12-10 14:20 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141210142003.GA15524@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=anjanasasindran123@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.