* [PATCH] staging: rts5208: Removed the new typedefs
@ 2014-12-10 13:54 Anjana Sasindran
2014-12-10 14:20 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Anjana Sasindran @ 2014-12-10 13:54 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, devel, Anjana Sasindran
This patch fix the checkpatch.pl warning:
WARNING: do not add new typedefs
Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
---
drivers/staging/rts5208/rtsx_sys.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/rtsx_sys.h b/drivers/staging/rts5208/rtsx_sys.h
index 0b6b4d4..f04d997 100644
--- a/drivers/staging/rts5208/rtsx_sys.h
+++ b/drivers/staging/rts5208/rtsx_sys.h
@@ -28,7 +28,7 @@
#include "rtsx_chip.h"
#include "rtsx_card.h"
-typedef dma_addr_t ULONG_PTR;
+dma_addr_t ULONG_PTR;
static inline void rtsx_exclusive_enter_ss(struct rtsx_chip *chip)
{
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: rts5208: Removed the new typedefs
2014-12-10 13:54 [PATCH] staging: rts5208: Removed the new typedefs Anjana Sasindran
@ 2014-12-10 14:20 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-12-10 14:20 UTC (permalink / raw)
To: Anjana Sasindran; +Cc: linux-kernel, devel
On Wed, Dec 10, 2014 at 07:24:16PM +0530, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning:
>
> WARNING: do not add new typedefs
>
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
> ---
> drivers/staging/rts5208/rtsx_sys.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_sys.h b/drivers/staging/rts5208/rtsx_sys.h
> index 0b6b4d4..f04d997 100644
> --- a/drivers/staging/rts5208/rtsx_sys.h
> +++ b/drivers/staging/rts5208/rtsx_sys.h
> @@ -28,7 +28,7 @@
> #include "rtsx_chip.h"
> #include "rtsx_card.h"
>
> -typedef dma_addr_t ULONG_PTR;
> +dma_addr_t ULONG_PTR;
>
> static inline void rtsx_exclusive_enter_ss(struct rtsx_chip *chip)
> {
Please learn how the C language works before attempting to contribute to
the Linux kernel. You obviously didn't even test build this code, which
means you are trying to waste my time, a very rude thing to do to
someone else, don't you think?
*plonk*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-10 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-10 13:54 [PATCH] staging: rts5208: Removed the new typedefs Anjana Sasindran
2014-12-10 14:20 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.