Re: [PATCH v4 2/6] arm: dts: socfpga: add altera fpga manager

[Steffen Trumtrar <s.trumtrar@pengutronix.de>]

Hi!

On Tue, Dec 09, 2014 at 02:14:46PM -0600, atull@opensource.altera.com wrote:
> From: Alan Tull <atull@opensource.altera.com>
> 
> Add Altera FGPA manager to device tree.
> 
> Signed-off-by: Alan Tull <atull@opensource.altera.com>
> ---
>  arch/arm/boot/dts/socfpga.dtsi |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 4472fd9..bab98b6 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -751,5 +751,15 @@
>  			compatible = "altr,sys-mgr", "syscon";
>  			reg = <0xffd08000 0x4000>;
>  		};
> +
> +		hps_0_fpgamgr: fpgamgr@0xff706000 {
> +			compatible = "altr,fpga-mgr", "simple-bus";
> +			reg = <0xFF706000 0x1000
> +			       0xFFB90000 0x1000>;
> +			interrupts = <0 175 4>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges;
> +		};

The fpgamgr is NOT a bus. You don't need ranges and/or simple-bus.

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |