From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Felipe Balbi <balbi@ti.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: am437x-sk-evm.dts: fix LCD timings
Date: Wed, 10 Dec 2014 09:03:27 -0800 [thread overview]
Message-ID: <20141210170326.GF30437@atomide.com> (raw)
In-Reply-To: <1417765171-7384-1-git-send-email-tomi.valkeinen@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [141204 23:42]:
> The lcd0 node for am437x-sk-evm.dts contains bad LCD timings, and while
> they seem to work with a quick test, doing for example blank/unblank
> will give you a black display.
>
> This patch updates the timings to the 'typical' values from the LCD spec
> sheet.
>
> Also, the compatible string is completely bogus, as
> "osddisplays,osd057T0559-34ts" is _not_ a 480x272 panel. The panel on
> the board is a newhaven one. Update the compatible string to reflect
> this. Note that this hasn't caused any issues, as the "panel-dpi"
> matches the driver.
>
> Cc: <stable@vger.kernel.org> # v3.17+
> Tested-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Applying into omap-for-v3.19/fixes thanks.
Tony
> ---
> arch/arm/boot/dts/am437x-sk-evm.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
> index 859ff3d620ee..66071c7b3dde 100644
> --- a/arch/arm/boot/dts/am437x-sk-evm.dts
> +++ b/arch/arm/boot/dts/am437x-sk-evm.dts
> @@ -100,7 +100,7 @@
> };
>
> lcd0: display {
> - compatible = "osddisplays,osd057T0559-34ts", "panel-dpi";
> + compatible = "newhaven,nhd-4.3-480272ef-atxl", "panel-dpi";
> label = "lcd";
>
> pinctrl-names = "default";
> @@ -112,11 +112,11 @@
> clock-frequency = <9000000>;
> hactive = <480>;
> vactive = <272>;
> - hfront-porch = <8>;
> - hback-porch = <43>;
> - hsync-len = <4>;
> - vback-porch = <12>;
> - vfront-porch = <4>;
> + hfront-porch = <2>;
> + hback-porch = <2>;
> + hsync-len = <41>;
> + vfront-porch = <2>;
> + vback-porch = <2>;
> vsync-len = <10>;
> hsync-active = <0>;
> vsync-active = <0>;
> --
> 2.2.0
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: am437x-sk-evm.dts: fix LCD timings
Date: Wed, 10 Dec 2014 09:03:27 -0800 [thread overview]
Message-ID: <20141210170326.GF30437@atomide.com> (raw)
In-Reply-To: <1417765171-7384-1-git-send-email-tomi.valkeinen@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [141204 23:42]:
> The lcd0 node for am437x-sk-evm.dts contains bad LCD timings, and while
> they seem to work with a quick test, doing for example blank/unblank
> will give you a black display.
>
> This patch updates the timings to the 'typical' values from the LCD spec
> sheet.
>
> Also, the compatible string is completely bogus, as
> "osddisplays,osd057T0559-34ts" is _not_ a 480x272 panel. The panel on
> the board is a newhaven one. Update the compatible string to reflect
> this. Note that this hasn't caused any issues, as the "panel-dpi"
> matches the driver.
>
> Cc: <stable@vger.kernel.org> # v3.17+
> Tested-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Applying into omap-for-v3.19/fixes thanks.
Tony
> ---
> arch/arm/boot/dts/am437x-sk-evm.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
> index 859ff3d620ee..66071c7b3dde 100644
> --- a/arch/arm/boot/dts/am437x-sk-evm.dts
> +++ b/arch/arm/boot/dts/am437x-sk-evm.dts
> @@ -100,7 +100,7 @@
> };
>
> lcd0: display {
> - compatible = "osddisplays,osd057T0559-34ts", "panel-dpi";
> + compatible = "newhaven,nhd-4.3-480272ef-atxl", "panel-dpi";
> label = "lcd";
>
> pinctrl-names = "default";
> @@ -112,11 +112,11 @@
> clock-frequency = <9000000>;
> hactive = <480>;
> vactive = <272>;
> - hfront-porch = <8>;
> - hback-porch = <43>;
> - hsync-len = <4>;
> - vback-porch = <12>;
> - vfront-porch = <4>;
> + hfront-porch = <2>;
> + hback-porch = <2>;
> + hsync-len = <41>;
> + vfront-porch = <2>;
> + vback-porch = <2>;
> vsync-len = <10>;
> hsync-active = <0>;
> vsync-active = <0>;
> --
> 2.2.0
>
next prev parent reply other threads:[~2014-12-10 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 7:39 [PATCH] ARM: dts: am437x-sk-evm.dts: fix LCD timings Tomi Valkeinen
2014-12-05 7:39 ` Tomi Valkeinen
2014-12-10 17:03 ` Tony Lindgren [this message]
2014-12-10 17:03 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210170326.GF30437@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.