From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Vince Weaver <vince@deater.net>,
"Yan, Zheng" <zheng.z.yan@intel.com>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH 1/2] perf/x86/intel/uncore: Make sure only uncore events are collected
Date: Wed, 10 Dec 2014 15:51:16 -0800 [thread overview]
Message-ID: <20141210235116.GL10824@tassilo.jf.intel.com> (raw)
In-Reply-To: <1418243031-20367-2-git-send-email-jolsa@kernel.org>
On Wed, Dec 10, 2014 at 09:23:50PM +0100, Jiri Olsa wrote:
> The uncore_collect_events functions assumes that event group
> might contain only uncore events which is wrong, because it
> might contain any type of events.
>
> This bug leads to uncore framework touching 'not' uncore events,
> which could end up all sorts of bugs.
Thanks for tracking that down. Looks good to me.
-Andi
next prev parent reply other threads:[~2014-12-10 23:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 20:23 [PATCHSET/RFC 0/2] perf: Fix issues reported by perf fuzzer Jiri Olsa
2014-12-10 20:23 ` [PATCH 1/2] perf/x86/intel/uncore: Make sure only uncore events are collected Jiri Olsa
2014-12-10 23:51 ` Andi Kleen [this message]
2014-12-11 12:25 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2014-12-10 20:23 ` [PATCH 2/2] perf: Fix events installation during moving group Jiri Olsa
2014-12-11 12:25 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2014-12-11 10:26 ` [PATCHSET/RFC 0/2] perf: Fix issues reported by perf fuzzer Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210235116.GL10824@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=vince@deater.net \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.