All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: fstests@vger.kernel.org
Subject: Re: generic/256 test failure?
Date: Wed, 10 Dec 2014 21:15:17 -0500	[thread overview]
Message-ID: <20141211021517.GF3370@thunk.org> (raw)
In-Reply-To: <20141211005030.GA30240@thunk.org>

I figured it out; the problem is that Debian uses /bin/dash as the
default shell (which is good, it meant that most Debian systems didn't
get screwed by the bash security hole).  But it's also bad, because
xfstests has a few /bin/bashisms.  Normally, this isn't a problem
because most of the scripts are started by #!/bin/bash.  However, on
my test system fsgqa had a shell of /dev/sh, and in Debian this is
/bin/dash.

So there are a couple of ways I can fix this.

1) Document in README that fsgqa must use a shell of fsgqa to
/bin/bash or some tests might fail.

2) Change _user_do() to use "su -s /bin/bash $qa_user ...".

3) Change tests/generic/256 so that instead of

   	  _user_do "$XFS_IO_PROG -f -c \"pwrite 0 $file_size\" $dir/$file_count.bin &> /dev/null"

we use:

   	  _user_do "$XFS_IO_PROG -f -c \"pwrite 0 $file_size\" $dir/$file_count.bin > /dev/null 2>&1"

or:

   	  _user_do "$XFS_IO_PROG -f -c \"pwrite 0 $file_size\" $dir/$file_count.bin" &> /dev/null

Any preference which patch, if any, I should send?  (If #1, then we
probably document the fact that fsgqa must have a shell of bash).

Thanks,

							- Ted


  reply	other threads:[~2014-12-11  2:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11  0:50 generic/256 test failure? Theodore Ts'o
2014-12-11  2:15 ` Theodore Ts'o [this message]
2014-12-11  4:06   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141211021517.GF3370@thunk.org \
    --to=tytso@mit.edu \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.