[PATCH] ASoC: wm8750: Make VREF a VMID instead of OUTPUT widget

[PATCH] ASoC: wm8750: Make VREF a VMID instead of OUTPUT widget

[Lars-Peter Clausen]

Commit 04489eeb02a4 ("ALSA: wm8750: add missing VREF output") added the
previously missing VREF widget. And while adding the widget as OUTPUT widget
silences the error of the missing widget it should have rather been a VMID
widget.

The VREF widget is only used internally as a source for the VREF input of
the Out3 Mux. Selecting that input means that the path should be kept
powered up at the VREF/VMID voltage, but that there is no actual audio
signal. Using a VMID widget will do this, whereas using a OUTPUT widget will
simply cause the path to completely power down.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 sound/soc/codecs/wm8750.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm8750.c b/sound/soc/codecs/wm8750.c
index f6847fd..eb0a164 100644
--- a/sound/soc/codecs/wm8750.c
+++ b/sound/soc/codecs/wm8750.c
@@ -323,7 +323,7 @@ static const struct snd_soc_dapm_widget wm8750_dapm_widgets[] = {
 	SND_SOC_DAPM_OUTPUT("ROUT2"),
 	SND_SOC_DAPM_OUTPUT("MONO1"),
 	SND_SOC_DAPM_OUTPUT("OUT3"),
-	SND_SOC_DAPM_OUTPUT("VREF"),
+	SND_SOC_DAPM_VMID("VREF"),
 
 	SND_SOC_DAPM_INPUT("LINPUT1"),
 	SND_SOC_DAPM_INPUT("LINPUT2"),
-- 
1.8.0

Re: [PATCH] ASoC: wm8750: Make VREF a VMID instead of OUTPUT widget

[Charles Keepax]

On Mon, Dec 08, 2014 at 11:23:11AM +0100, Lars-Peter Clausen wrote:
> Commit 04489eeb02a4 ("ALSA: wm8750: add missing VREF output") added the
> previously missing VREF widget. And while adding the widget as OUTPUT widget
> silences the error of the missing widget it should have rather been a VMID
> widget.
> 
> The VREF widget is only used internally as a source for the VREF input of
> the Out3 Mux. Selecting that input means that the path should be kept
> powered up at the VREF/VMID voltage, but that there is no actual audio
> signal. Using a VMID widget will do this, whereas using a OUTPUT widget will
> simply cause the path to completely power down.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

Re: [PATCH] ASoC: wm8750: Make VREF a VMID instead of OUTPUT widget

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 326 bytes --]

On Mon, Dec 08, 2014 at 11:23:11AM +0100, Lars-Peter Clausen wrote:
> Commit 04489eeb02a4 ("ALSA: wm8750: add missing VREF output") added the
> previously missing VREF widget. And while adding the widget as OUTPUT widget
> silences the error of the missing widget it should have rather been a VMID
> widget.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]