From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: patches pending acks (or naks) Date: Thu, 11 Dec 2014 14:41:48 -0500 Message-ID: <20141211194148.GG18992@laptop.dumpdata.com> References: <5489906B020000780004EE34@mail.emea.novell.com> <69DD4F40-ADC1-48A4-9BD0-0A2A00624F66@oracle.com> <5489C88F020000780004F0C2@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xz9cc-0002aO-Uz for xen-devel@lists.xenproject.org; Thu, 11 Dec 2014 19:41:59 +0000 Content-Disposition: inline In-Reply-To: <5489C88F020000780004F0C2@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Campbell , xen-devel , Keir Fraser , Ian Jackson , Tim Deegan List-Id: xen-devel@lists.xenproject.org On Thu, Dec 11, 2014 at 03:38:39PM +0000, Jan Beulich wrote: > >>> On 11.12.14 at 16:18, wrote: > > On December 11, 2014 6:39:07 AM EST, Jan Beulich wrote: > >>Either > >>http://lists.xenproject.org/archives/html/xen-devel/2014-12/msg00260.html > >>or (my preference) > >>http://lists.xenproject.org/archives/html/xen-devel/2014-12/msg01054.html > >> > > > > Daniel's patch fixes the case for EFI map or large CPU count (to a certain > > extent). Jan's patch only fixes it for large CPU count. The memmap can be > > huge on small CPU count machines. > > The EFI memory map gets printed much later than when the ring > buffer gets set up with "conring_size=" present. Right.. > > > A proper fix would be to automatically adjust based on memmap and CPU but > > that could be too complex. > > The problem isn't the complexity, but the chicken-and-egg problem > as far as CPU count is concerned. The memory map size would be > known early enough. Let me explain my thought process: - There are existing knobs that can be used to change this (conring_size=X) - But we would like an awesome release where those knobs don't have to be used. - The patch you posted could be reworked to fully address memmap and CPU. - I don't know what your time constraints are for said patch and you might not have the energy to rework it. - I don't want to put pressure on you or Daniel on having to write new patches - especially as folks are going on vacation soon. Hence as a fallback I believe that Daniel's patch should go in and Jan's patch can go in too. However if Jan (or somebody else) wants to rework the v2 (or a new one) to address the memmap issue then that patch would go in - instead of Daniel's or v2 of Jan patch. > > Jan >