From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/8] arch: FDPIC is not supported on m68k
Date: Thu, 11 Dec 2014 21:05:32 +0100 [thread overview]
Message-ID: <20141211200532.GD4199@free.fr> (raw)
In-Reply-To: <1417642895-29606-4-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2014-12-03 22:41 +0100, Thomas Petazzoni spake thusly:
> The current binfmt selection in arch/Config.in allows to select FDPIC
> on m68k, which is incorrect. This commit fixes that, and makes sure
> FDPIC is the default on Blackfin, while FLAT is the default on m68k.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
After reading your reply, it does make sense to keep explicit defaults,
rather than rely on the ordering of the options in the choice. So:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> arch/Config.in | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/Config.in b/arch/Config.in
> index 2779ab6..3bac187 100644
> --- a/arch/Config.in
> +++ b/arch/Config.in
> @@ -255,7 +255,8 @@ config BR2_ARCH_HAS_ATOMICS
> choice
> prompt "Target Binary Format"
> depends on BR2_bfin || BR2_m68k
> - default BR2_BINFMT_FDPIC
> + default BR2_BINFMT_FDPIC if BR2_bfin
> + default BR2_BINFMT_FLAT if BR2_m68k
>
> config BR2_BINFMT_ELF
> bool "ELF"
> @@ -267,7 +268,7 @@ config BR2_BINFMT_ELF
>
> config BR2_BINFMT_FDPIC
> bool "FDPIC"
> - depends on BR2_bfin || BR2_m68k
> + depends on BR2_bfin
> help
> ELF FDPIC binaries are based on ELF, but allow the individual load
> segments of a binary to be located in memory independently of each
> --
> 2.1.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-12-11 20:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 21:41 [Buildroot] [PATCH 0/8] Improving static/shared library selection Thomas Petazzoni
2014-12-03 21:41 ` [Buildroot] [PATCH 1/8] docs: fix typo in cmake-package documentation Thomas Petazzoni
2014-12-03 21:49 ` Samuel Martin
2014-12-03 22:11 ` Yann E. MORIN
2014-12-07 20:54 ` Thomas Petazzoni
2014-12-03 21:41 ` [Buildroot] [PATCH 2/8] Rename BR2_PREFER_STATIC_LIB to BR2_STATIC_LIBS Thomas Petazzoni
2014-12-11 18:44 ` Yann E. MORIN
2014-12-11 18:49 ` Thomas Petazzoni
2014-12-11 20:08 ` Yann E. MORIN
2014-12-03 21:41 ` [Buildroot] [PATCH 3/8] arch: FDPIC is not supported on m68k Thomas Petazzoni
2014-12-11 18:49 ` Yann E. MORIN
2014-12-11 19:01 ` Thomas Petazzoni
2014-12-11 20:05 ` Yann E. MORIN [this message]
2014-12-03 21:41 ` [Buildroot] [PATCH 4/8] arch: ensure BR2_BINFMT_ELF is really used Thomas Petazzoni
2014-12-11 20:07 ` Yann E. MORIN
2014-12-11 21:50 ` Thomas Petazzoni
2014-12-03 21:41 ` [Buildroot] [PATCH 5/8] arch: introduce BR2_BINFMT_SUPPORTS_SHARED Thomas Petazzoni
2014-12-11 20:12 ` Yann E. MORIN
2014-12-11 21:53 ` Thomas Petazzoni
2014-12-03 21:41 ` [Buildroot] [PATCH 6/8] ncurses: speed up host build by disabling static library building Thomas Petazzoni
2014-12-11 20:24 ` Yann E. MORIN
2014-12-03 21:41 ` [Buildroot] [PATCH 7/8] Turn the static lib option into a choice with more options Thomas Petazzoni
2014-12-11 20:46 ` Yann E. MORIN
2014-12-03 21:41 ` [Buildroot] [PATCH 8/8] Build shared libraries only as the default Thomas Petazzoni
2014-12-11 20:49 ` Yann E. MORIN
2014-12-11 21:54 ` [Buildroot] [PATCH 0/8] Improving static/shared library selection Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211200532.GD4199@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.