From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:33203 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758846AbaLKXvJ (ORCPT ); Thu, 11 Dec 2014 18:51:09 -0500 Date: Fri, 12 Dec 2014 10:50:53 +1100 From: Dave Chinner Subject: Re: [PATCH v2] generic/299: various fixes Message-ID: <20141211235053.GH24183@dastard> References: <1418294952-20035-1-git-send-email-eguan@redhat.com> <1418295529-20565-1-git-send-email-eguan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418295529-20565-1-git-send-email-eguan@redhat.com> Sender: fstests-owner@vger.kernel.org To: Eryu Guan Cc: fstests@vger.kernel.org List-ID: On Thu, Dec 11, 2014 at 06:58:49PM +0800, Eryu Guan wrote: > Fix three problems in generic/299 > > 1. Use $XFS_IO_PROG instead of fallocate/truncate, old distros like > RHEL5 don't have these commands. > > 2. Remove $seqres.full before test, otherwise the file is growing all > the time. > > 3. Make sure fio really exits, otherwise fio would block umount. $pid is > the pid of function run_check not fio, sometimes fio is still there when > $pid is dead and blocking umount. > > Signed-off-by: Eryu Guan > --- > > v2: > - remove $seqres.full before _require_fio, which writes to $seqres.full too Does not apply after Eric's earlier patch "[PATCH] use xfs_io falloc, not fallocate". Once I push out an updated tree with this patch in it, can you rebase this patch and resend it? Cheers, Dave. -- Dave Chinner david@fromorbit.com