From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Linux Filesystem Development List <linux-fsdevel@vger.kernel.org>,
fstests@vger.kernel.org
Subject: Re: [PATCH] xfstests: generic/315: make sure the test file exists and is zero length
Date: Fri, 12 Dec 2014 16:21:59 +1100 [thread overview]
Message-ID: <20141212052159.GL24183@dastard> (raw)
In-Reply-To: <1418267623-29612-1-git-send-email-tytso@mit.edu>
[cc fstests@vger.kernel.org]
On Wed, Dec 10, 2014 at 10:13:43PM -0500, Theodore Ts'o wrote:
> Before we determine how much space is available to be fallocated, and
> before trying to fallocate the file, we need to make sure testfile.315
> exists and is zero-length. Otherwise the fallocate program will fail
> the first time generic/315 is run on a freshly mkfs'ed file system:
>
> generic/315 0s ... [06:31:43] [06:31:44] [failed, exit status 1] - output mismatch (see /results/results-ext3conv/generic/315.out.bad)
> --- tests/generic/315.out 2014-10-31 10:13:04.000000000 -0400
> +++ /results/results-ext3conv/generic/315.out.bad 2014-11-24 06:31:44.111279060 -0500
> @@ -1,2 +1,6 @@
> QA output created by 315
> Slience is golden
> +ls: cannot access /vdd/testfile.315: No such file or directory
> +./tests/generic/315: line 69: [: : integer expression expected
> +File size is changed to ( Bytes)
> +(see /results/results-ext3conv/generic/315.full for details)
Already fixed by commit ca28228 ("generic: use xfs_io falloc, not
fallocate").
Yet another demonstration of why we have a "use xfs_io whereever
possible" rule for new tests: we don't have to hack around semantic
oddities of random CLI tools. ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2014-12-12 5:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 3:13 [PATCH] xfstests: generic/315: make sure the test file exists and is zero length Theodore Ts'o
2014-12-12 5:21 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141212052159.GL24183@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.