From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd Date: Fri, 12 Dec 2014 12:37:51 +0100 Message-ID: <20141212113751.GA5367@aepfle.de> References: <1417781152-9926-6-git-send-email-olaf@aepfle.de> <21633.41977.399042.691409@mariner.uk.xensource.com> <20141208123736.GA3691@aepfle.de> <21639.7875.160312.349247@mariner.uk.xensource.com> <20141209162740.GA14288@aepfle.de> <21639.10108.666942.407514@mariner.uk.xensource.com> <20141210091534.GA24974@aepfle.de> <1418205728.19809.40.camel@citrix.com> <20141210175251.GA4441@aepfle.de> <1418379056.23309.45.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1418379056.23309.45.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , xen-devel@lists.xen.org, Wei Liu , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Fri, Dec 12, Ian Campbell wrote: > Seems ok. I wonder if the wrapper ought to source > @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons to obtain XENSTORED_* itself > rather than relying on the initscript and unit file to do so. Especially > in the initscript case it looks a bit ugly to have to manually propagate > things. It seems all that wrapping is of no use because SELinux can not deal with it. I will see if "ExecStart=/bin/ary --no-fork $ENVVAR" can be used to pass additional arguments. If so, the current XENSTORED_TRACE handling has to be removed in favour of XENSTORED_ARGS=. Olaf