From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE
 in systemd
Date: Fri, 12 Dec 2014 13:12:36 +0100
Message-ID: <20141212121236.GA8380@aepfle.de>
References: <21633.41977.399042.691409@mariner.uk.xensource.com>
	<20141208123736.GA3691@aepfle.de>
	<21639.7875.160312.349247@mariner.uk.xensource.com>
	<20141209162740.GA14288@aepfle.de>
	<21639.10108.666942.407514@mariner.uk.xensource.com>
	<20141210091534.GA24974@aepfle.de>
	<1418205728.19809.40.camel@citrix.com>
	<20141210175251.GA4441@aepfle.de>
	<1418379056.23309.45.camel@citrix.com>
	<20141212113751.GA5367@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20141212113751.GA5367@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, M A Young <m.a.young@durham.ac.uk>, konrad.wilk@oracle.com
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xen.org, Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Dec 12, Olaf Hering wrote:

> On Fri, Dec 12, Ian Campbell wrote:
> 
> > Seems ok. I wonder if the wrapper ought to source
> > @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons to obtain XENSTORED_* itself
> > rather than relying on the initscript and unit file to do so. Especially
> > in the initscript case it looks a bit ugly to have to manually propagate
> > things.
> 
> It seems all that wrapping is of no use because SELinux can not deal
> with it. I will see if "ExecStart=/bin/ary --no-fork $ENVVAR" can be
> used to pass additional arguments. If so, the current XENSTORED_TRACE
> handling has to be removed in favour of XENSTORED_ARGS=.

This works:
ExecStart=@XENSTORED@ --no-fork $XENSTORED_ARGS

This fails:
ExecStart=$XENSTORED --no-fork $XENSTORED_ARGS
Dez 12 13:06:21 optiplex systemd[1]: [/usr/lib/systemd/system/xenstored.service:16] Executable path is not absolute, ignoring: $XENSTORED --no-fork $XENSTORED_ARGS

Looks like variables are not expanded for the executable itself. If that
really has to be supported a wrapper is required.

Maybe that new wrapper script just needs some special SELinux handling?
No idea.

Olaf