Re: [Qemu-devel] [PATCH 4/4] block: vhdx - set .bdrv_has_zero_init to bdrv_has_zero_init_1

[Jeff Cody <jcody@redhat.com>]

On Fri, Dec 12, 2014 at 09:43:16AM -0500, Lokesha, Amulya wrote:
>    Hi Max,
> 
>     

Please reply in-line, it makes it easier to follow technical
discussions - thanks :)

> 
>    We applied all the 5 patches from the mail chain I got since the last
>    week. Please find attached the patches used by us.
> 
>    We were unable to apply the patch3 as it failed with the following error
> 
>     
> 
>    # patch -p1 < patch3
> 
>    patching file block/vhdx.c
> 
>    patch: **** malformed patch at line 17:          error_setg_errno(errp,
>    EINVAL, "Image size too large; max of 64TB"); @@ -1936,7 +1936,9 @@ static
>    QemuOptsList vhdx_create_opts = {
> 
>

It looks like however you saved the patch file, it was corrupted.
Looking at your attached patch 3, it split line 9 across 2 lines.
Your patch also has whitespace differences from the patch I sent.

You also attached 5 patches - Why are you using patch 0?  You should
only be applying patches 1-4.  This should not be causing any actual
issues, however.

Are you using git for your qemu version?  If so, 'git am' is the
preferred method of applying the patches - just save each of the patch
emails (the whole email should be fine), and run 'git am' on each
file.


> 
>     
> 
>    Hence, we manually added the patch3 changes and recompiled the qemu. We
>    then used the patched qemu-img to convert  our vmdk image to dynamic VHDX
>    format. We found that the image created this time had a considerable
>    decrease in its size from 50GB to 12GB.
> 

Could you tell me the file size of the VMDK image you were converting?
Is it roughly 12GB as well?

>    However, when we deployed it into our SCVMM 2012, the import of the VHDX
>    image failed with a "syntax error" as below
> 
>     
> 
>    Information (10804)
> 
>    Unable to import \\Test.com\Library\VHDs\Test-disk1.vhdx because of a
>    syntax error in the file.
> 
>     

If you run qemu-img info on Test-disk1.vhdx, what does it say?

> 
>    Please let us know if we missed anything.
> 
>     
> 
>    Thanks,
> 
>    Amulya
> 
>     
>

[...]

Jeff