From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XzR5k-00059n-Tf for mharc-grub-devel@gnu.org; Fri, 12 Dec 2014 09:21:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzR5Z-00057p-TQ for grub-devel@gnu.org; Fri, 12 Dec 2014 09:21:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzR5P-0001l2-Lr for grub-devel@gnu.org; Fri, 12 Dec 2014 09:21:00 -0500 Received: from mail-la0-x232.google.com ([2a00:1450:4010:c03::232]:45901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzR5P-0001ky-DV for grub-devel@gnu.org; Fri, 12 Dec 2014 09:20:51 -0500 Received: by mail-la0-f50.google.com with SMTP id pn19so6159859lab.37 for ; Fri, 12 Dec 2014 06:20:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=wfltmyMOjrLxAyV/EBnZwRWeqTFvjIxLhk8Kex/UXfQ=; b=JijRLM6wgGyfqjSkHl1FueZfZEVJo7K0VjC5UpY7mTI7FLNKCBJNKtNbuqGNgqEom7 vBeU0Y6VyHsJaSj8KWSwUjRNSpeIbDW+CbPPVSjYIjsBDyPcx96KyyueialEj5OJ0nOz 4XHSZI6nMMh+P8w//2hnK1kaXbH2ZzSL9vFUxucnCekpsuoyfcz7FLvnskzYl6oJCD4I wGdx/9AG5kkafcAo3FFq0cNdM+8IR1X+eNoetZwQfrpp/v7jmPHnAGp9YtSt8ta/Yx6Q TGvfSXYm7xEBu7wXEcI/IzLc7gA/BA27hgDRKVRe8MysT0wAxcoNBZgt2a9BtPePsWEj 9v7g== X-Received: by 10.112.199.40 with SMTP id jh8mr15861355lbc.5.1418394050629; Fri, 12 Dec 2014 06:20:50 -0800 (PST) Received: from opensuse.site (ppp91-76-15-25.pppoe.mtu-net.ru. [91.76.15.25]) by mx.google.com with ESMTPSA id tl8sm422587lbb.47.2014.12.12.06.20.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Dec 2014 06:20:49 -0800 (PST) Date: Fri, 12 Dec 2014 17:20:47 +0300 From: Andrei Borzenkov To: Victor Lowther Subject: Re: [PATCH] Allow nonstandard ports when specifying network protocols. Message-ID: <20141212172047.667d4f86@opensuse.site> In-Reply-To: References: <20141212145436.198c0324@opensuse.site> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::232 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Dec 2014 14:21:11 -0000 =D0=92 Fri, 12 Dec 2014 07:01:31 -0600 Victor Lowther =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Fri, Dec 12, 2014 at 5:54 AM, Andrei Borzenkov w= rote: > > =D0=92 Thu, 11 Dec 2014 13:58:04 -0600 > > Victor Lowther =D0=BF=D0=B8=D1=88=D0=B5=D1= =82: > > > >> There are usecases for running TFTP and HTTP on nonstandard ports. Th= is > >> patch allows you to specify nonstandard ports with the following synta= x: >=20 > [ snip ] >=20 > > No, that's wrong. grub_net_open_real should not have any hardcoded > > dependencies on supported protocols. "pxe" and "pxe:" are just for > > compatibility with legacy configuration. Any new code should rely on > > protocol modules registration. >=20 > Er, it seemed like the natural place based on it being the only place whe= re > the parsing happens. >=20 > Where should I put it then? >=20 In the same function after we got server name. Just check whether it has extra ',' and parse accordingly. > > Do not overcomplicate things. You just need to add additional server > > name parsing after protocol was extracted. >=20 > My familiarity with the grub codebase started on Tuesday -- I have no idea > what is overcomplicated and what is not. >=20 > > And please also update documentation to indicate new syntax. >=20 > Where are the docs? Nothing jumped out at me when grepping through the > codebase. docs/grub.texi. It is mentioned in 13.1 How to specify devices. Yes, documentation needs some love.