All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>,
	Netfilter Development Mailing list
	<netfilter-devel@vger.kernel.org>
Subject: Re: src: add redirect support
Date: Fri, 12 Dec 2014 19:51:56 +0100	[thread overview]
Message-ID: <20141212185156.GA3311@salvia> (raw)
In-Reply-To: <20141212183612.GA3177@acer.localdomain>

On Fri, Dec 12, 2014 at 06:36:13PM +0000, Patrick McHardy wrote:
> On 12.12, Pablo Neira Ayuso wrote:
> > On Fri, Dec 12, 2014 at 05:27:03PM +0000, Patrick McHardy wrote:
> > > Am 12. Dezember 2014 17:02:04 GMT+00:00, schrieb Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>:
> > > >
> > > >Do you want me to change the syntax? I can do it this weekend. Just
> > > >let me know :-)
> > > 
> > > Well, I don't think the colon is really bad, however it suggests an
> > > address can be put in front of it. I guess the reason is an
> > > ambiguity in the grammar with following expressions otherwise. Even
> > > though redirect is terminal the grammar so far doesn't know about
> > > it. From a readability POV I like a simple "to".
> > 
> > I also like "to". Patch attached to address this.
> > 
> > > >If you are going to change it yourself, I would suggest to also update
> > > >regression tests [0], which BTW seems broken due to the
> > > >random-fully/fully-random change.
> > > 
> > > I missed that, will fix it up later.
> > 
> > No problem, just fixed it here, will push it now.
> 
> Great, thanks.
> 
> I'll push my concat changes soon unless I hear objections :)

Thanks Patrick.

Let's release 0.4, OK?

Do you want to include your concat changes already in this release?

P.S: It's great to see concat extension finally landing, that's a
killer feature :-).

  reply	other threads:[~2014-12-12 18:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-12 15:29 src: add redirect support Patrick McHardy
2014-12-12 17:02 ` Arturo Borrero Gonzalez
2014-12-12 17:27   ` Patrick McHardy
2014-12-12 18:33     ` Pablo Neira Ayuso
2014-12-12 18:36       ` Patrick McHardy
2014-12-12 18:51         ` Pablo Neira Ayuso [this message]
2014-12-12 18:53           ` Patrick McHardy
2014-12-12 19:29             ` Pablo Neira Ayuso
2014-12-12 19:34               ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141212185156.GA3311@salvia \
    --to=pablo@netfilter.org \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.