All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugene Korenevsky <ekorenevsky@gmail.com>
To: kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH] kvm-unit-tests: minor: remove unused variable
Date: Fri, 12 Dec 2014 22:54:05 +0300	[thread overview]
Message-ID: <20141212195405.GA12318@gnote> (raw)

Remove unused variable to get rid of compiler warning.
And remove commented out code (it can always be restored
from git logs).

Signed-off-by: Eugene Korenevsky <ekorenevsky@gmail.com>
---
 x86/vmx_tests.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index 184fafc..0daaacf 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -1439,12 +1439,10 @@ static int dbgctls_init(struct vmcs *vmcs)
 
 static void dbgctls_main(void)
 {
-	u64 dr7, debugctl;
+	u64 dr7;
 
 	asm volatile("mov %%dr7,%0" : "=r" (dr7));
-	debugctl = rdmsr(MSR_IA32_DEBUGCTLMSR);
-	/* Commented out: KVM does not support DEBUGCTL so far */
-	report("Load debug controls", dr7 == 0x404 /* && debugctl == 0x2 */);
+	report("Load debug controls", dr7 == 0x404);
 
 	dr7 = 0x408;
 	asm volatile("mov %0,%%dr7" : : "r" (dr7));
@@ -1463,9 +1461,7 @@ static void dbgctls_main(void)
 	vmcall();
 
 	asm volatile("mov %%dr7,%0" : "=r" (dr7));
-	debugctl = rdmsr(MSR_IA32_DEBUGCTLMSR);
-	/* Commented out: KVM does not support DEBUGCTL so far */
-	report("Guest=host debug controls", dr7 == 0x402 /* && debugctl == 0x1 */);
+	report("Guest=host debug controls", dr7 == 0x402);
 
 	dr7 = 0x408;
 	asm volatile("mov %0,%%dr7" : : "r" (dr7));
-- 
2.0.4


             reply	other threads:[~2014-12-12 19:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-12 19:54 Eugene Korenevsky [this message]
2014-12-15 15:01 ` [PATCH] kvm-unit-tests: minor: remove unused variable Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141212195405.GA12318@gnote \
    --to=ekorenevsky@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.