From: Ondrej Zary <linux@rainbow-software.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: David Miller <davem@davemloft.net>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] e100: Don't enable WoL by default on Toshiba devices
Date: Fri, 12 Dec 2014 22:11:26 +0100 [thread overview]
Message-ID: <201412122211.27074.linux@rainbow-software.org> (raw)
In-Reply-To: <1415849927.2454.14.camel@jtkirshe-mobl>
On Thursday 13 November 2014 04:38:47 Jeff Kirsher wrote:
> On Wed, 2014-11-12 at 18:18 -0500, David Miller wrote:
> > From: Ondrej Zary <linux@rainbow-software.org>
> > Date: Wed, 12 Nov 2014 23:47:25 +0100
> >
> > > Enabling WoL on some Toshiba laptops (such as Portege R100) causes
> > > battery drain after shutdown (WoL is active even on battery). These
> > > laptops have the WoL bit set in EEPROM ID, causing e100 driver to
> > > enable WoL by default.
> > >
> > > Check subsystem vendor ID and if it's Toshiba, don't enable WoL by
> > > default from EEPROM settings.
> > >
> > > Fixes https://bugs.launchpad.net/ubuntu/+source/linux/+bug/110784
> > >
> > > Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> >
> > Jeff, are you gonna pick this up?
>
> Yes, sorry I did not catch it earlier.
Will this go in 3.19?
--
Ondrej Zary
next prev parent reply other threads:[~2014-12-12 21:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 22:47 [PATCH] e100: Don't enable WoL by default on Toshiba devices Ondrej Zary
2014-11-12 23:18 ` David Miller
2014-11-13 3:38 ` Jeff Kirsher
2014-11-13 3:38 ` Jeff Kirsher
2014-12-12 21:11 ` Ondrej Zary [this message]
2015-01-15 13:40 ` Ondrej Zary
2015-01-15 14:53 ` Jeff Kirsher
2015-01-15 15:18 ` Ondrej Zary
2015-01-15 15:18 ` Ondrej Zary
2015-01-15 15:31 ` Jeff Kirsher
2015-01-15 15:31 ` Jeff Kirsher
2015-01-15 20:15 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412122211.27074.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.