All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v3] generic/299: various fixes
Date: Sun, 14 Dec 2014 17:12:21 -0500	[thread overview]
Message-ID: <20141214221221.GP29787@thunk.org> (raw)
In-Reply-To: <1418359401-8240-1-git-send-email-eguan@redhat.com>

On Fri, Dec 12, 2014 at 12:43:21PM +0800, Eryu Guan wrote:
> @@ -136,7 +138,7 @@ _workout()
>  	    done
>  	    # Following like will check that pid is still run.
>  	    # Once fio exit we can stop fallocate/truncate loop
> -	    kill -0 $pid > /dev/null 2>&1 || break
> +	    pgrep fio > /dev/null 2>&1 || break
>  	done
>  	wait $pid

This patch is causing generic/299 to loop forever for me.  The problem
is that "fio" is too easy to match:

root@kvm-xfstests:~# pgrep fio
1407
root@kvm-xfstests:~# ps augxww | grep 1407
root      1407  0.0  0.0      0     0 ?        S<   16:52   0:00 [dm_bufio_cache]
root      8386  0.0  0.0   2704   492 ttyS1    S+   17:06   0:00 grep 1407

I'm currently a testing a patch which uses "pgrep -f $XFS_IO_PROG"
instead, but I'm a bit surprised no once else noticed this, I guess
people aren't building their xfstests test kernels with DM_SNAPSHOP or
DM_VERITY configured (either of which will seleect DM_BUFIO)?

	  	     	     	      	   - Ted

  reply	other threads:[~2014-12-14 22:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11 10:49 [PATCH] generic/299: various fixes Eryu Guan
2014-12-11 10:58 ` [PATCH v2] " Eryu Guan
2014-12-11 23:50   ` Dave Chinner
2014-12-12  2:51     ` Eryu Guan
2014-12-12  4:43   ` [PATCH v3] " Eryu Guan
2014-12-14 22:12     ` Theodore Ts'o [this message]
2014-12-14 22:17       ` Theodore Ts'o
2014-12-15  3:52         ` Eryu Guan
2014-12-15  5:02     ` [PATCH v4] " Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141214221221.GP29787@thunk.org \
    --to=tytso@mit.edu \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.