From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] ATM: HE: Cleanup coding style
Date: Sun, 14 Dec 2014 20:34:27 -0800 [thread overview]
Message-ID: <20141215043427.GA3949@kroah.com> (raw)
In-Reply-To: <CAOLa=ZRN2k9vGBgSd-8zk1PUUZBHc_NxDfqfe8Xj1y7S+dPPfA@mail.gmail.com>
On Mon, Dec 15, 2014 at 04:23:18AM +0000, karthik nayak wrote:
>
> On Mon, Dec 15, 2014, 7:31 AM?Greg KH <greg@kroah.com> wrote:
>
> On Sun, Dec 14, 2014 at 07:36:23PM -0600, Jonathan Jin wrote:
> > This patch cleans up the following coding style issues that are detected
> by
> > checkpatch:
> >? ? ? ? ?ERROR: trailing whitespace
> >? ? ? ? ?ERROR: open brace '{' following struct go on the same line
>
> Don't do multiple things in the same patch, make this at least 2
> patches.
>
> greg k-h
>
> (Sorry, replied on my phone, default was not set to reply all.)
>
> Wouldn't this count as one checkpatch fix patch? I mean, being the same file.
Nope, you are doing two different _types_ of checkpatch fixes. So it
needs to be more than one patch.
Remember, you need to make it as easy as possible for a maintainer to
read your patch, doing more than one thing in a patch makes it much
harder, and it gives them an easy reason to reject to it.
greg k-h
next prev parent reply other threads:[~2014-12-15 4:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 1:36 [PATCH] ATM: HE: Cleanup coding style Jonathan Jin
2014-12-15 1:40 ` Jonathan Jin
2014-12-15 1:59 ` Greg KH
2014-12-15 4:23 ` karthik nayak
2014-12-15 4:34 ` Greg KH [this message]
2014-12-15 5:17 ` karthik nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215043427.GA3949@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.