From: Tobias Klauser <tklauser@distanz.ch>
To: David Miller <davem@davemloft.net>
Cc: tony@atomide.com, nico@fluxnic.net, netdev@vger.kernel.org
Subject: Re: [PATCH net v2] net: smc91x: Fix build without gpiolib
Date: Mon, 15 Dec 2014 09:56:38 +0100 [thread overview]
Message-ID: <20141215085637.GL16916@distanz.ch> (raw)
In-Reply-To: <20141212.115838.1155760587618419145.davem@davemloft.net>
On 2014-12-12 at 17:58:38 +0100, David Miller <davem@davemloft.net> wrote:
> From: Tobias Klauser <tklauser@distanz.ch>
> Date: Fri, 12 Dec 2014 17:45:29 +0100
>
> > On 2014-12-12 at 17:30:20 +0100, David Miller <davem@davemloft.net> wrote:
> >> In my opinion, if the code blocks enabling the configurations that
> >> need this are enabled, so should GPIO be depended upon.
> >>
> >> I think, at a minimum, when CONFIG_OF is enabled smsc91x should
> >> require GPIO.
> >
> > Agreed. This is the better solution, causing less surprises for the
> > user. Should this be a "select GPIOLIB if OF" then?
>
> If GPIO is a child node in the Kconfig hierarchy (ie. has no
> dependencies of it's own), then yes. Otherwise, a depends
> will need to be used, because select does not recursively
> trigger a select'd nodes dependencies.
Thank you for the explanation. Since GPIOLIB depends on
ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB, I think it's
appropriate to let SMC91X depend on (!OF || GPIOLIB). I'll send an
updated patch.
prev parent reply other threads:[~2014-12-15 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 16:07 [PATCH net v2] net: smc91x: Fix build without gpiolib Tobias Klauser
2014-12-12 16:11 ` Tony Lindgren
2014-12-12 16:21 ` David Miller
2014-12-12 16:27 ` Tobias Klauser
2014-12-12 16:30 ` David Miller
2014-12-12 16:34 ` Tony Lindgren
2014-12-12 16:45 ` Tobias Klauser
2014-12-12 16:58 ` David Miller
2014-12-15 8:56 ` Tobias Klauser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215085637.GL16916@distanz.ch \
--to=tklauser@distanz.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.