From: Daniel Vetter <daniel@ffwll.ch>
To: "Kannan, Vandana" <vandana.kannan@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 8/8] drm/i915: Add drrs_interval module parameter
Date: Mon, 15 Dec 2014 15:38:10 +0100 [thread overview]
Message-ID: <20141215143810.GD27182@phenom.ffwll.local> (raw)
In-Reply-To: <548EEF80.50002@intel.com>
On Mon, Dec 15, 2014 at 07:56:08PM +0530, Kannan, Vandana wrote:
>
>
> On 15-Dec-14 7:46 PM, Daniel Vetter wrote:
> >On Mon, Dec 15, 2014 at 04:25:32PM +0530, Kannan, Vandana wrote:
> >>
> >>
> >>On 15-Dec-14 3:17 PM, Daniel Vetter wrote:
> >>>On Thu, Dec 11, 2014 at 02:22:57AM +0530, Vandana Kannan wrote:
> >>>>Adding i915 module parameter for setting drrs_interval. If this param is
> >>>>set to 0, then drrs is disabled. If changed in runtime, then the new interval
> >>>>value will be considered for scheduling the next drrs work.
> >>>>drrs_interval is set to 0 by default, i.e. DRRS is disabled by default.
> >>>
> >>>Nope, please don't hide power saving features behind module options by
> >>>default. New stuff must be enabled by default, otherwise it'll bitrot and
> >>>merging to upstream is fairly useless since we still have the rebase pain
> >>>(just spread out over more people) with none of the testing.
> >>ok.. so, shall I just make the delay (drrs_interval) fixed at 1 second
> >>or let user set this delay at runtime through the same module param
> >>(excluding the disable feature if interval is 0 part) ?
> >
> >Imo we should just set an optimal value (does vbt have any hints?).
> >
> VBT does not contain a delay value..
> Based on data collected from testing so far, 1 second seems stable..
> Maybe it can go down to 800ms or so - I can test it out..
> Anything as low as 100ms just triggered too many RR switches back and forth.
There's not need imo to go to the lowest possible value, there's always a
tradeoff. 1s sounds good (psr has even worse timeout on some panels ...).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-15 14:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 20:52 [PATCH 0/8] eDP DRRS based on frontbuffer tracking Vandana Kannan
2014-12-10 20:52 ` [PATCH 1/8] drm/i915: Modifying structures related to DRRS Vandana Kannan
2014-12-10 20:52 ` [PATCH 2/8] drm/i915: Initialize DRRS delayed work Vandana Kannan
2014-12-10 20:52 ` [PATCH 3/8] drm/i915: Enable/disable DRRS Vandana Kannan
2014-12-10 20:52 ` [PATCH 4/8] drm/i915: DRRS calls based on frontbuffer Vandana Kannan
2014-12-15 9:57 ` Daniel Vetter
2014-12-15 14:15 ` Kannan, Vandana
2014-12-15 14:24 ` Daniel Vetter
2014-12-10 20:52 ` [PATCH 5/8] drm/i915/bdw: Add support for DRRS to switch RR Vandana Kannan
2014-12-10 20:52 ` [PATCH 6/8] drm/i915: Support for RR switching on VLV Vandana Kannan
2014-12-10 20:52 ` [PATCH 7/8] drm/i915: Enable eDP DRRS for CHV Vandana Kannan
2014-12-10 20:52 ` [PATCH 8/8] drm/i915: Add drrs_interval module parameter Vandana Kannan
2014-12-11 6:10 ` shuang.he
2014-12-15 9:47 ` Daniel Vetter
2014-12-15 10:55 ` Kannan, Vandana
2014-12-15 14:16 ` Daniel Vetter
2014-12-15 14:26 ` Kannan, Vandana
2014-12-15 14:38 ` Daniel Vetter [this message]
2014-12-15 10:00 ` [PATCH 0/8] eDP DRRS based on frontbuffer tracking Daniel Vetter
2014-12-15 14:00 ` Kannan, Vandana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215143810.GD27182@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vandana.kannan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.