From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/skl: Skylake also supports DP MST
Date: Mon, 15 Dec 2014 15:42:45 +0100 [thread overview]
Message-ID: <20141215144245.GF27182@phenom.ffwll.local> (raw)
In-Reply-To: <1418394418-10517-3-git-send-email-damien.lespiau@intel.com>
On Fri, Dec 12, 2014 at 02:26:58PM +0000, Damien Lespiau wrote:
> I've checked that TRANS_DDI_MODE, DP_TP_CTL MST bits are identical to
> HSW/BDW on SKL, as well as the long vs short HPD bits. So we have a good
> chance to be working as well as prevous platforms.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 3fc3296..8e276c4 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5085,7 +5085,7 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port,
> intel_dp_aux_init(intel_dp, intel_connector);
>
> /* init MST on ports that can support it */
> - if (IS_HASWELL(dev) || IS_BROADWELL(dev)) {
> + if (IS_HASWELL(dev) || IS_BROADWELL(dev) || INTEL_INFO(dev)->gen >= 9) {
HAS_DDI might be a nice bikeshed here if you're bored. Applied both to
dinq.
Thanks, Daniel
> if (port == PORT_B || port == PORT_C || port == PORT_D) {
> intel_dp_mst_encoder_init(intel_dig_port,
> intel_connector->base.base.id);
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-12-15 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 14:26 [PATCH 0/2] Enable DP MST encoders for SKL Damien Lespiau
2014-12-12 14:26 ` [PATCH 1/2] drm/i915: Consolidate DDI clock reading out in a single function Damien Lespiau
2014-12-12 14:26 ` [PATCH 2/2] drm/i915/skl: Skylake also supports DP MST Damien Lespiau
2014-12-14 7:48 ` shuang.he
2014-12-14 20:39 ` Dave Airlie
2014-12-15 14:42 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215144245.GF27182@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.