From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from akt59.rev.netart.pl (akt59.rev.netart.pl [85.128.150.59]) by mail.openembedded.org (Postfix) with ESMTP id BE2FD7255D for ; Mon, 15 Dec 2014 19:37:15 +0000 (UTC) Received: from localhost (unknown [78.8.74.197]) by open-rnd.nazwa.pl (Postfix) with ESMTP id 6489A442AB9; Mon, 15 Dec 2014 20:37:13 +0100 (CET) Date: Mon, 15 Dec 2014 20:37:12 +0100 From: Maciej Borzecki To: Tom Zanussi Message-ID: <20141215193712.GA3659@localhost.localdomain> References: <1418211958-27738-1-git-send-email-maciej.borzecki@open-rnd.pl> <1418663085.25212.13.camel@picadillo> MIME-Version: 1.0 In-Reply-To: <1418663085.25212.13.camel@picadillo> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Cc: Maciek Borzecki , Rifenbark Scott , openembedded-core@lists.openembedded.org Subject: Re: [PATCH 0/3] wic: glob support & minor fixes X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Dec 2014 19:37:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On 12/15 11:04, Tom Zanussi wrote: > On Wed, 2014-12-10 at 12:45 +0100, Maciej Borzecki wrote: > > This patch series adds changes that enable globbing in IMAGE_BOOT_FILES. > > Effectivey this makes use of with with Raspberry Pi a tad easier, when a > > lengthy list of boot files can be replaced with just one entry. A related > > change to meta-raspberrypi will be sent to the Yocto mailing list. > > > > Looks ok to me, and I tried it out with your raspberrypi layer changes > which generated the image (I didn't try any other image types to check > against regressions there, though nothing in here looks like it would > touch anything related to the other source plugins, so I'm not worried - > in the next milestone I hope to have some automated wic testing going to > make checking easy). > > I do think, though, that we need to have the documentation for this in > the tool itself. As it stands, the IMAGE_BOOT_FILES variable is > documented in the manual, but even then, there's no context that ties it > to the bootimg-partition plugin. I think we need to add a mechanism so > that help text can be added to each plugin, which would be automatically > picked up and merged probably into a plugin-specific 'help plugins' > section in the tool. > > The other thing I noticed, which has nothing to do with this patchset, > but along the same lines, is that the plugin machinery does find the > sdimage-raspberrypi.wks file to generate the image, as expected, but it > doesn't show up in 'wic list source-plugins', as you'd expect. That's expected, there is no separate source plugin for sdimage-raspberrypi.wks. The kickstart file makes use of bootimage-partition, so it's effectively almost identical to sdimage-bootpart.wks but the boot partition size and start offset. So far the only development boards that will not directly work with wic's current plugins are Freescale ones (ex. popular iMX6 boards like Wandboard, Nitrogen6x, Sable Lite etc.). These boards expect u-boot to be located just after MBR, hence the use case is somewhat similar to what pcibios source plugin covers. > > Acked-by: Tom Zanussi > > > Maciej Borzecki (3): > > wic: IMAGE_BOOT_FILES format checks in bootimg-partition source > > wic: add globbing support in IMAGE_BOOT_FILES entries > > ref-manual: update IMAGE_BOOT_FILES entry > > > > documentation/ref-manual/ref-variables.xml | 37 +++++++++++++++---- > > .../lib/wic/plugins/source/bootimg-partition.py | 43 +++++++++++++++++----- > > 2 files changed, 64 insertions(+), 16 deletions(-) > > > > -- > > 1.9.3 > > > > -- Maciej Borzęcki Senior Software Developer at Open-RnD Sp. z o.o., Poland www.open-rnd.pl mobile: +48 889 117 365, fax: +48 42 657 9079 Niniejsza wiadomość wraz z załącznikami może zawierać chronione prawem lub poufne informacje i została wysłana wyłącznie do wiadomości i użytku osób, do których została zaadresowana. Jeśli wiadomość została otrzymana przypadkowo zabrania się jej kopiowania lub rozsyłania do osób trzecich. W takim przypadku uprasza się o natychmiastowe zniszczenie wiadomości oraz poinformowanie nadawcy o zaistniałej sytuacji za pomocą wiadomości zwrotnej. Dziękujemy. This message, including any attachments hereto, may contain privileged or confidential information and is sent solely for the attention and use of the intended addressee(s). If you are not an intended addressee, you may neither use this message nor copy or deliver it to anyone. In such case, you should immediately destroy this message and kindly notify the sender by reply email. Thank you.