From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: imx: support arm power off in cpuidle for i.mx6sx
Date: Tue, 16 Dec 2014 16:24:42 +0800 [thread overview]
Message-ID: <20141216082441.GH2411@dragon> (raw)
In-Reply-To: <1418102919-29950-2-git-send-email-b20788@freescale.com>
On Tue, Dec 09, 2014 at 01:28:39PM +0800, Anson Huang wrote:
> This patch introduces an independent cpuidle driver for
> i.MX6SX, and supports arm power off in idle, totally
> 3 levels of cpuidle are supported as below:
>
> 1. ARM WFI;
> 2. SOC in WAIT mode;
> 3. SOC in WAIT mode + ARM power off.
>
> ARM power off can save at least 5mW power.
>
> Signed-off-by: Anson Huang <b20788@freescale.com>
Looks pretty nice, except one small comment below.
> ---
> arch/arm/mach-imx/Makefile | 3 +-
> arch/arm/mach-imx/common.h | 4 ++
> arch/arm/mach-imx/cpuidle-imx6sx.c | 107 ++++++++++++++++++++++++++++++++++++
> arch/arm/mach-imx/cpuidle.h | 5 ++
> arch/arm/mach-imx/gpc.c | 25 ++++++++-
> arch/arm/mach-imx/mach-imx6sx.c | 2 +-
> arch/arm/mach-imx/pm-imx6.c | 2 +-
> 7 files changed, 142 insertions(+), 6 deletions(-)
> create mode 100644 arch/arm/mach-imx/cpuidle-imx6sx.c
...
> --- a/arch/arm/mach-imx/pm-imx6.c
> +++ b/arch/arm/mach-imx/pm-imx6.c
> @@ -205,7 +205,7 @@ void imx6q_set_int_mem_clk_lpm(bool enable)
> writel_relaxed(val, ccm_base + CGPR);
> }
>
> -static void imx6q_enable_rbc(bool enable)
> +void imx6q_enable_rbc(bool enable)
We may want to take the chance to rename it to imx6_enable_rbc().
Shawn
> {
> u32 val;
>
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2014-12-16 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 5:28 [PATCH 1/2] arm: imx: remove unnecessary setting for DSM Anson Huang
2014-12-09 5:28 ` [PATCH 2/2] arm: imx: support arm power off in cpuidle for i.mx6sx Anson Huang
2014-12-16 8:24 ` Shawn Guo [this message]
2014-12-16 8:23 ` [PATCH 1/2] arm: imx: remove unnecessary setting for DSM Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216082441.GH2411@dragon \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.