From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: tame the chattermouth (v2)
Date: Tue, 16 Dec 2014 09:53:04 +0100 [thread overview]
Message-ID: <20141216085304.GL2711@phenom.ffwll.local> (raw)
In-Reply-To: <871to0k6hy.fsf@intel.com>
On Mon, Dec 15, 2014 at 10:22:49PM +0200, Jani Nikula wrote:
> On Mon, 15 Dec 2014, Rob Clark <robdclark@gmail.com> wrote:
> > Many distro's have mechanism in place to collect and automatically file
> > bugs for failed WARN()s. And since i915 has a lot of hw state sanity
> > checks which result in WARN(), it generates quite a lot of noise which
> > is somewhat disconcerting to the end user.
> >
> > Separate out the internal hw-is-in-the-state-I-expected checks into
> > I915_STATE_WARN()s and allow configuration via i915.verbose_checks module
> > param about whether this will generate a full blown stacktrace or just
> > DRM_ERROR(). The new moduleparam defaults to true, so by default there
> > is no change in behavior. And even when disabled, you will still get
> > an error message logged.
> >
> > v2: paint the macro names blue, clarify that the default behavior
> > remains the same as before
> >
> > Signed-off-by: Rob Clark <robdclark@gmail.com>
>
> FWIW this is
>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
>
> even though I opposed v1. While I'm still not thrilled by an extra
> module param, my main concern was alleviated by Rob pointing out to me
> the default of that param leaves old behaviour unchanged.
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-12-16 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 18:56 [PATCH] drm/i915: tame the chattermouth (v2) Rob Clark
2014-12-15 20:22 ` Jani Nikula
2014-12-16 8:53 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216085304.GL2711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.