From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Brilliantov Kirill Vladimirovich <brilliantov@inbox.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Oleg Drokin <oleg.drokin@intel.com>,
Greg Donald <gdonald@gmail.com>,
HPDD-discuss@ml01.01.org
Subject: Re: [PATCH] staging: lustre: lustre: osc: lproc_osc.c: Fix for possible null pointer dereference
Date: Tue, 16 Dec 2014 12:26:13 +0300 [thread overview]
Message-ID: <20141216092613.GF4856@mwanda> (raw)
In-Reply-To: <CAFo99gZXxEgZMgZ4Vc0yKjm8AYdrGTkZZ3Yr4j_HNuPEPUUFbw@mail.gmail.com>
On Tue, Dec 16, 2014 at 12:07:19AM +0100, Rickard Strandqvist wrote:
> Hi Dan
>
> Quite right! Had to try it.
>
> Do nothing then?
> But you must agree that it is still ugly and confusing code.
>
Yes. I agree that it's confusing. I also suspect that "obd" is never
NULL but I haven't actually looked and these things are sometimes
complicated to verify.
I fine with merging the patch as a cleanup.
Smatch has code to not warn about these but it's not 100% correct so
it still warns sometimes when it shouldn't.
regards,
dan carpenter
prev parent reply other threads:[~2014-12-16 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 22:37 [PATCH] staging: lustre: lustre: osc: lproc_osc.c: Fix for possible null pointer dereference Rickard Strandqvist
2014-12-15 10:25 ` Dan Carpenter
2014-12-15 23:07 ` Rickard Strandqvist
2014-12-16 9:26 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216092613.GF4856@mwanda \
--to=dan.carpenter@oracle.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=brilliantov@inbox.ru \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.