All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Joe Perches <joe@perches.com>,
	devel@driverdev.osuosl.org, Fabian Frederick <fabf@skynet.be>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	James Simmons <uja.ornl@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Oleg Drokin <oleg.drokin@intel.com>,
	Greg Donald <gdonald@gmail.com>,
	HPDD-discuss@ml01.01.org,
	Andriy Skulysh <Andriy_Skulysh@xyratex.com>,
	"John L. Hammond" <john.hammond@intel.com>
Subject: Re: [PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c: Fix for possible null pointer dereference
Date: Tue, 16 Dec 2014 12:27:17 +0300	[thread overview]
Message-ID: <20141216092717.GG4856@mwanda> (raw)
In-Reply-To: <CAFo99gaVUbsvwY7RKZ9D=c0jnVeFiBLAeNVb53UX=Ba4XytoKg@mail.gmail.com>

On Mon, Dec 15, 2014 at 11:23:25PM +0100, Rickard Strandqvist wrote:
> Hi Joe
> 
> No, it does not look like end can be NULL then.
> Then remove the end != NULL instead?
> ...
>     if (end != NULL && *end == '.') {
> 

Yes.  Please do.

regards,
dan carpenter


  parent reply	other threads:[~2014-12-16  9:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-14 22:52 [PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c: Fix for possible null pointer dereference Rickard Strandqvist
2014-12-15  1:51 ` Joe Perches
2014-12-15 22:23   ` Rickard Strandqvist
2014-12-15 23:53     ` Joe Perches
2014-12-16  3:08       ` [HPDD-discuss] " Patrick Farrell
2014-12-16  9:27     ` Dan Carpenter [this message]
2014-12-16  4:40 ` Chris Rorvick
  -- strict thread matches above, loose matches on Subject: below --
2014-12-14 22:36 Rickard Strandqvist
2014-12-14 22:39 ` Greg Kroah-Hartman
2014-12-14 22:43   ` Rickard Strandqvist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141216092717.GG4856@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=Andriy_Skulysh@xyratex.com \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fabf@skynet.be \
    --cc=gdonald@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=john.hammond@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    --cc=rickard_strandqvist@spectrumdigital.se \
    --cc=uja.ornl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.