All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kasagar, Srinidhi" <srinidhi.kasagar@intel.com>
To: Len Brown <lenb@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Brown, Len" <len.brown@intel.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	vishwesh.m.rudramuni@intel.com, srinidhi.kasagar@intel.com
Subject: Re: [PATCH v7] cpufreq: Add SFI based cpufreq driver support
Date: Tue, 16 Dec 2014 15:54:44 +0530	[thread overview]
Message-ID: <20141216102444.GA16158@intel-desktop> (raw)
In-Reply-To: <CAJvTdKmCwJTWE4t9YuWn+OLxG5EWZDXo5LZ1Bxq45ECiOvQmsA@mail.gmail.com>

On Tue, Dec 16, 2014 at 03:15:33AM -0500, Len Brown wrote:

[...]

> replace line above with...
> 
> policy->cpuinfo.transition_latency = CPUFREQ_ETERNAL;

But we know the transition latency of this system. Why should we
claim it as "unknown"? The sfi_freq_table_entry has latency
field - does it not make irrelevant then?

> 
> ondemand will compare this to TRANSITION_LATENCY_LIMIT (10 * 1000 * 1000)
> and since -1 is less than 10,000,000; it will be happy.
> 
> > +       for (i = 0; i < num_freq_table_entries; i++) {
> > +               /* detect transition latency */
> > +               if ((sfi_cpufreq_array[i].latency * 1000) >
> > +                   policy->cpuinfo.transition_latency)
> > +                       policy->cpuinfo.transition_latency =
> > +                               sfi_cpufreq_array[i].latency * 1000;
> 
> delete above 5 lines.  every SFI system will have latency
> plenty lower than that required by ondemand governor.

Srinidhi

  reply	other threads:[~2014-12-16 10:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11  8:14 [PATCH v7] cpufreq: Add SFI based cpufreq driver support Srinidhi Kasagar
2014-12-11  8:22 ` Viresh Kumar
2014-12-11  9:13   ` Kasagar, Srinidhi
2014-12-16  8:15 ` Len Brown
2014-12-16 10:24   ` Kasagar, Srinidhi [this message]
2014-12-17 22:12     ` Len Brown
2014-12-18  6:44       ` Kasagar, Srinidhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141216102444.GA16158@intel-desktop \
    --to=srinidhi.kasagar@intel.com \
    --cc=len.brown@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    --cc=vishwesh.m.rudramuni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.