diff for duplicates of <20141216235144.GA31467@mwanda> diff --git a/a/1.txt b/N1/1.txt index bb9cb69..f566895 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -36,7 +36,7 @@ index 7223b00..31426ae 100644 struct bfad_itnim_s **itnim_drv) { *itnim_drv = kzalloc(sizeof(struct bfad_itnim_s), GFP_ATOMIC); - if (*itnim_drv = NULL) + if (*itnim_drv == NULL) - return; + return -ENOMEM; @@ -64,7 +64,7 @@ index 6dc7926..829247e 100644 * call bfad to allocate the itnim */ - bfa_fcb_itnim_alloc(port->fcs->bfad, &itnim, &itnim_drv); -- if (itnim = NULL) { +- if (itnim == NULL) { + ret = bfa_fcb_itnim_alloc(port->fcs->bfad, &itnim, &itnim_drv); + if (ret) { bfa_trc(port->fcs, rport->pwwn); diff --git a/a/content_digest b/N1/content_digest index 7e81391..3df5a58 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling\0" - "Date\0Tue, 16 Dec 2014 23:51:44 +0000\0" + "Date\0Wed, 17 Dec 2014 02:51:44 +0300\0" "To\0Anil Gurumurthy <anil.gurumurthy@qlogic.com>\0" "Cc\0Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>" James E.J. Bottomley <JBottomley@parallels.com> @@ -46,7 +46,7 @@ " \t\t struct bfad_itnim_s **itnim_drv)\n" " {\n" " \t*itnim_drv = kzalloc(sizeof(struct bfad_itnim_s), GFP_ATOMIC);\n" - " \tif (*itnim_drv = NULL)\n" + " \tif (*itnim_drv == NULL)\n" "-\t\treturn;\n" "+\t\treturn -ENOMEM;\n" " \n" @@ -74,11 +74,11 @@ " \t * call bfad to allocate the itnim\n" " \t */\n" "-\tbfa_fcb_itnim_alloc(port->fcs->bfad, &itnim, &itnim_drv);\n" - "-\tif (itnim = NULL) {\n" + "-\tif (itnim == NULL) {\n" "+\tret = bfa_fcb_itnim_alloc(port->fcs->bfad, &itnim, &itnim_drv);\n" "+\tif (ret) {\n" " \t\tbfa_trc(port->fcs, rport->pwwn);\n" " \t\treturn NULL;\n" " \t}" -a49567da7e169a1c53c5f5faa3f5e368fa900ca5396064b1411e7bc3bcd1b5ce +5381a488e946102d86524daf95b1d9caf8f424e68f715b6872a879c6495d4882
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.