From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <treding@nvidia.com>
Subject: Re: drm/dsi: Add message to packet translator
Date: Wed, 17 Dec 2014 11:58:06 +0100
Message-ID: <20141217105805.GD5646@ulmo.nvidia.com>
References: <20141216235305.GC31467@mwanda>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2127137315=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143])
 by gabe.freedesktop.org (Postfix) with ESMTP id 196956E412
 for <dri-devel@lists.freedesktop.org>; Wed, 17 Dec 2014 02:58:47 -0800 (PST)
In-Reply-To: <20141216235305.GC31467@mwanda>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

--===============2127137315==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="3Pql8miugIZX0722"
Content-Disposition: inline

--3Pql8miugIZX0722
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 17, 2014 at 02:53:05AM +0300, Dan Carpenter wrote:
> Hello Thierry Reding,
>=20
> This is a semi-automatic email about new static checker warnings.
>=20
> The patch a52879e8d7cb: "drm/dsi: Add message to packet translator"=20
> from Oct 16, 2014, leads to the following Smatch complaint:
>=20
> drivers/gpu/drm/drm_mipi_dsi.c:328 mipi_dsi_create_packet()
> 	 warn: variable dereferenced before check 'msg' (see line 326)
>=20
> drivers/gpu/drm/drm_mipi_dsi.c
>    325	{
>    326		const u8 *tx =3D msg->tx_buf;
>                                ^^^^^^^^^^^
> Dereference.
>=20
>    327=09
>    328		if (!packet || !msg)
>                                ^^^^
> Check.
>=20
>    329			return -EINVAL;
>    330=09
>=20
> regards,
> dan carpenter

I've had a patch in my tree for almost two weeks now, I wonder why this
is still there...

Ah, forgot to push it of course. Done now.

Thierry

--3Pql8miugIZX0722
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUkWG9AAoJEN0jrNd/PrOhktkP/jkrDYdt08Y4m5Cx9gMrGVRs
hV7PdPhEFWzL5jAZDtDAtyEggx6zkp80FQaMNfpvb2FbDvARLNDl8i9knJinTJnh
t26mXAxrWTr6Q05D/hRzZekS+frhAbz0StO84HTWaIPLWppBFqFblr0XSbiF5FV3
jywAjuOBWReq7Jj9mkGeQenf9WF+OEjnk/xvry/FeOmmwJK+DCIJ/MCNWVlxorAU
YOdEsTw7x3Y6mep9wsgYlZaqGOkjiw4OMEIRZMF2Yirqw5VdyAkgF8y+IWXA8mgW
0BC8Z17HK3yIwuDG0VRuGRp+cr8SE6s/mzXuJ+SZmLAtw2HfeQ7LydlT0TR58MXf
6cWi+NxrY6PzC6QKMEb95VfYG/DCSyQPYEP1CRfFyPGY8k1wFiV5m7xj/NiuoqqZ
xo1jMb6S6xwsmHGruV9hpq92Y7Wj7CIC2zMT2KabaBw7NaqpZlWCt9TLSaPQD9v3
SYuymGALVtgDWb+YXwH0GGc63MVmLwowgPvKlfrvIYJ3zprjLjGygVdZT9e89oNG
FcVjGdTnR7c+6p3mG5q3ux0xPTbrFx3Hce5M30WG+TlDAMYSwcjirMaqcPwnYtad
9+dVAKckGLN9jgcSq0RKCr1ipbhCgcOFC6OtgvWa3P2Bzfrjz7OnBsdbfRWkrK75
1w/zIDl2xIRPhFomDYOo
=6OY0
-----END PGP SIGNATURE-----

--3Pql8miugIZX0722--

--===============2127137315==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK

--===============2127137315==--