From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/dsi: Do the 'msg' check prior to dereferencing it. Date: Wed, 17 Dec 2014 11:59:21 +0100 Message-ID: <20141217105920.GE5646@ulmo.nvidia.com> References: <1418774674-14390-1-git-send-email-festevam@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0868336387==" Return-path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 876576E0DC for ; Wed, 17 Dec 2014 02:59:45 -0800 (PST) In-Reply-To: <1418774674-14390-1-git-send-email-festevam@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabio Estevam Cc: Fabio Estevam , dan.carpenter@oracle.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0868336387== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="maH1Gajj2nflutpK" Content-Disposition: inline --maH1Gajj2nflutpK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 16, 2014 at 10:04:34PM -0200, Fabio Estevam wrote: > From: Fabio Estevam >=20 > Commit a52879e8d7cb ("drm/dsi: Add message to packet translator") caused = the > following Smatch complaint: >=20 > drivers/gpu/drm/drm_mipi_dsi.c:328 mipi_dsi_create_packet() > warn: variable dereferenced before check 'msg' (see line 326) >=20 > Do the 'msg' check prior to dereferencing it. >=20 > Reported-by: Dan Carpenter =20 > Signed-off-by: Fabio Estevam > --- > drivers/gpu/drm/drm_mipi_dsi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) I've had an equivalent patch in the drm/panel tree for almost two weeks but had forgotten to push. Pushed now. Thierry --maH1Gajj2nflutpK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUkWIIAAoJEN0jrNd/PrOhnsUQAJh3RDYnvQwe8GSGH/m8s3rU OSxfKwSkPGxiMNYovt3LlYGZ5UQWIaUQP4CTUa49aVs5wUpeaTLj6V6mwMDnSWZS ZtvCE4FQAw2qN0jasck8eqDSkJ/2+SypDBHMmT918COtr+4oNRoA4isDBTvUQO1V WpDTPRagvI1ZDXU+/S+CgSnvnyT4W8ZeD+F2+Qy7g9JXGvLCFNnaHwOBI8+Vapl6 owfO7yzDCu5St2gpUY2l2rITJ1EQExIeFdmxZ6EPTioKsOzyCd6TkxiRa9AkAt7c Vdk0sbLLiexdZOXRfCUPwnFZ+ayB4j8BQOd5lBzta3bCsr2krycU5S2gakAO5SM6 m+W3KPsLWexYHQnG0owOaPkFpUHaeuIkP2qammdrB8+tE8R7WrMoBM3Y8jNELr/+ c7WnPNRBOHv+Cwf9Rn/CrYCSA9+WMLKZJgW7AxwOZR64nPbv04Y/Z1KBjsOUCW3+ HmWDea2yqS96g1OqFjUwJ76wS8kn4LisV2POrZd933RqDhBj3Xz3iBzWjhOh74fh mScgfG5H2tDSzDR2XjbD8zf/bNzZCm4uI/qs7KHoabZhjtmju5nYE3xwDnAEKgGA 6K4JVfoCjHnUh5B5Bz44awMyYrENxsdZ6GP32/cR7kUTbxGvKIg6tcHeGomla5B8 oFZMDWdiXQ8SPooFk4u5 =2+DX -----END PGP SIGNATURE----- --maH1Gajj2nflutpK-- --===============0868336387== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0868336387==--