From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 02/13] drm: store property instead of id in obj attachment Date: Wed, 17 Dec 2014 14:29:10 +0100 Message-ID: <20141217132910.GF2711@phenom.ffwll.local> References: <1418771141-16954-1-git-send-email-robdclark@gmail.com> <1418771141-16954-3-git-send-email-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E90E6E0E5 for ; Wed, 17 Dec 2014 05:28:35 -0800 (PST) Received: by mail-wg0-f44.google.com with SMTP id b13so20215251wgh.17 for ; Wed, 17 Dec 2014 05:28:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <1418771141-16954-3-git-send-email-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBEZWMgMTYsIDIwMTQgYXQgMDY6MDU6MzBQTSAtMDUwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IEtlZXAgcHJvcGVydHkgcG9pbnRlciwgaW5zdGVhZCBvZiBpZCwgaW4gcGVyIG1vZGUtb2Jq ZWN0IGF0dGFjaG1lbnRzLgo+IFRoaXMgd2lsbCBzaW1wbGlmeSB0aGluZ3MgaW4gbGF0ZXIgcGF0 Y2hlcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBSb2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5jb20+ CgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jIHwgMTcgKysrKysrKystLS0tLS0tLS0K PiAgaW5jbHVkZS9kcm0vZHJtX2NydGMuaCAgICAgfCAgNyArKysrKystCj4gIDIgZmlsZXMgY2hh bmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMK PiBpbmRleCA1ZWU0Yjg4Li4yNzgwYTA4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiBAQCAtMjEwNSwx MiArMjEwNSwxMSBAQCBpbnQgZHJtX21vZGVfZ2V0Y29ubmVjdG9yKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsIHZvaWQgKmRhdGEsCj4gIAkJcHJvcF9wdHIgPSAodWludDMyX3QgX191c2VyICopKHVu c2lnbmVkIGxvbmcpKG91dF9yZXNwLT5wcm9wc19wdHIpOwo+ICAJCXByb3BfdmFsdWVzID0gKHVp bnQ2NF90IF9fdXNlciAqKSh1bnNpZ25lZCBsb25nKShvdXRfcmVzcC0+cHJvcF92YWx1ZXNfcHRy KTsKPiAgCQlmb3IgKGkgPSAwOyBpIDwgY29ubmVjdG9yLT5wcm9wZXJ0aWVzLmNvdW50OyBpKysp IHsKPiAtCQkJaWYgKHB1dF91c2VyKGNvbm5lY3Rvci0+cHJvcGVydGllcy5pZHNbaV0sCj4gLQkJ CQkgICAgIHByb3BfcHRyICsgY29waWVkKSkgewo+ICsJCQlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpw cm9wID0gY29ubmVjdG9yLT5wcm9wZXJ0aWVzLnByb3BlcnRpZXNbaV07Cj4gKwkJCWlmIChwdXRf dXNlcihwcm9wLT5iYXNlLmlkLCBwcm9wX3B0ciArIGNvcGllZCkpIHsKPiAgCQkJCXJldCA9IC1F RkFVTFQ7Cj4gIAkJCQlnb3RvIG91dDsKPiAgCQkJfQo+IC0KPiAgCQkJaWYgKHB1dF91c2VyKGNv bm5lY3Rvci0+cHJvcGVydGllcy52YWx1ZXNbaV0sCj4gIAkJCQkgICAgIHByb3BfdmFsdWVzICsg Y29waWVkKSkgewo+ICAJCQkJcmV0ID0gLUVGQVVMVDsKPiBAQCAtMzgyMiw3ICszODIxLDcgQEAg dm9pZCBkcm1fb2JqZWN0X2F0dGFjaF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX21vZGVfb2JqZWN0ICpv YmosCj4gIAkJcmV0dXJuOwo+ICAJfQo+ICAKPiAtCW9iai0+cHJvcGVydGllcy0+aWRzW2NvdW50 XSA9IHByb3BlcnR5LT5iYXNlLmlkOwo+ICsJb2JqLT5wcm9wZXJ0aWVzLT5wcm9wZXJ0aWVzW2Nv dW50XSA9IHByb3BlcnR5Owo+ICAJb2JqLT5wcm9wZXJ0aWVzLT52YWx1ZXNbY291bnRdID0gaW5p dF92YWw7Cj4gIAlvYmotPnByb3BlcnRpZXMtPmNvdW50Kys7Cj4gIH0KPiBAQCAtMzg0Nyw3ICsz ODQ2LDcgQEAgaW50IGRybV9vYmplY3RfcHJvcGVydHlfc2V0X3ZhbHVlKHN0cnVjdCBkcm1fbW9k ZV9vYmplY3QgKm9iaiwKPiAgCWludCBpOwo+ICAKPiAgCWZvciAoaSA9IDA7IGkgPCBvYmotPnBy b3BlcnRpZXMtPmNvdW50OyBpKyspIHsKPiAtCQlpZiAob2JqLT5wcm9wZXJ0aWVzLT5pZHNbaV0g PT0gcHJvcGVydHktPmJhc2UuaWQpIHsKPiArCQlpZiAob2JqLT5wcm9wZXJ0aWVzLT5wcm9wZXJ0 aWVzW2ldID09IHByb3BlcnR5KSB7Cj4gIAkJCW9iai0+cHJvcGVydGllcy0+dmFsdWVzW2ldID0g dmFsOwo+ICAJCQlyZXR1cm4gMDsKPiAgCQl9Cj4gQEAgLTM4NzcsNyArMzg3Niw3IEBAIGludCBk cm1fb2JqZWN0X3Byb3BlcnR5X2dldF92YWx1ZShzdHJ1Y3QgZHJtX21vZGVfb2JqZWN0ICpvYmos Cj4gIAlpbnQgaTsKPiAgCj4gIAlmb3IgKGkgPSAwOyBpIDwgb2JqLT5wcm9wZXJ0aWVzLT5jb3Vu dDsgaSsrKSB7Cj4gLQkJaWYgKG9iai0+cHJvcGVydGllcy0+aWRzW2ldID09IHByb3BlcnR5LT5i YXNlLmlkKSB7Cj4gKwkJaWYgKG9iai0+cHJvcGVydGllcy0+cHJvcGVydGllc1tpXSA9PSBwcm9w ZXJ0eSkgewo+ICAJCQkqdmFsID0gb2JqLT5wcm9wZXJ0aWVzLT52YWx1ZXNbaV07Cj4gIAkJCXJl dHVybiAwOwo+ICAJCX0KPiBAQCAtNDQxMyw4ICs0NDEyLDggQEAgaW50IGRybV9tb2RlX29ial9n ZXRfcHJvcGVydGllc19pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ ICAJCXByb3BfdmFsdWVzX3B0ciA9ICh1aW50NjRfdCBfX3VzZXIgKikodW5zaWduZWQgbG9uZykK PiAgCQkJCSAgKGFyZy0+cHJvcF92YWx1ZXNfcHRyKTsKPiAgCQlmb3IgKGkgPSAwOyBpIDwgcHJv cHNfY291bnQ7IGkrKykgewo+IC0JCQlpZiAocHV0X3VzZXIob2JqLT5wcm9wZXJ0aWVzLT5pZHNb aV0sCj4gLQkJCQkgICAgIHByb3BzX3B0ciArIGNvcGllZCkpIHsKPiArCQkJc3RydWN0IGRybV9w cm9wZXJ0eSAqcHJvcCA9IG9iai0+cHJvcGVydGllcy0+cHJvcGVydGllc1tpXTsKPiArCQkJaWYg KHB1dF91c2VyKHByb3AtPmJhc2UuaWQsIHByb3BzX3B0ciArIGNvcGllZCkpIHsKPiAgCQkJCXJl dCA9IC1FRkFVTFQ7Cj4gIAkJCQlnb3RvIG91dDsKPiAgCQkJfQo+IEBAIC00NDcyLDcgKzQ0NzEs NyBAQCBpbnQgZHJtX21vZGVfb2JqX3NldF9wcm9wZXJ0eV9pb2N0bChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJCWdvdG8gb3V0Owo+ICAKPiAgCWZvciAoaSA9IDA7IGkg PCBhcmdfb2JqLT5wcm9wZXJ0aWVzLT5jb3VudDsgaSsrKQo+IC0JCWlmIChhcmdfb2JqLT5wcm9w ZXJ0aWVzLT5pZHNbaV0gPT0gYXJnLT5wcm9wX2lkKQo+ICsJCWlmIChhcmdfb2JqLT5wcm9wZXJ0 aWVzLT5wcm9wZXJ0aWVzW2ldLT5iYXNlLmlkID09IGFyZy0+cHJvcF9pZCkKPiAgCQkJYnJlYWs7 Cj4gIAo+ICAJaWYgKGkgPT0gYXJnX29iai0+cHJvcGVydGllcy0+Y291bnQpCj4gZGlmZiAtLWdp dCBhL2luY2x1ZGUvZHJtL2RybV9jcnRjLmggYi9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4gaW5k ZXggYjg2MzI5OC4uMDI3NThlOCAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fY3J0Yy5o Cj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2NydGMuaAo+IEBAIC02NCw3ICs2NCwxMiBAQCBzdHJ1 Y3QgZHJtX21vZGVfb2JqZWN0IHsKPiAgI2RlZmluZSBEUk1fT0JKRUNUX01BWF9QUk9QRVJUWSAy NAo+ICBzdHJ1Y3QgZHJtX29iamVjdF9wcm9wZXJ0aWVzIHsKPiAgCWludCBjb3VudDsKPiAtCXVp bnQzMl90IGlkc1tEUk1fT0JKRUNUX01BWF9QUk9QRVJUWV07Cj4gKwkvKiBOT1RFOiBpZiB3ZSBl dmVyIHN0YXJ0IGR5bmFtaWNhbGx5IGRlc3Ryb3lpbmcgcHJvcGVydGllcyAoaWUuCj4gKwkgKiBu b3QgYXQgZHJtX21vZGVfY29uZmlnX2NsZWFudXAoKSB0aW1lKSwgdGhlbiB3ZSdkIGhhdmUgdG8g ZG8KPiArCSAqIGEgYmV0dGVyIGpvYiBvZiBkZXRhY2hpbmcgcHJvcGVydHkgZnJvbSBtb2RlIG9i amVjdHMgdG8gYXZvaWQKPiArCSAqIGRhbmdsaW5nIHByb3BlcnR5IHBvaW50ZXJzOgo+ICsJICov Cj4gKwlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpwcm9wZXJ0aWVzW0RSTV9PQkpFQ1RfTUFYX1BST1BF UlRZXTsKPiAgCXVpbnQ2NF90IHZhbHVlc1tEUk1fT0JKRUNUX01BWF9QUk9QRVJUWV07Cj4gIH07 Cj4gIAo+IC0tIAo+IDIuMS4wCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl ciwgSW50ZWwgQ29ycG9yYXRpb24KKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5m ZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=