From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 03/13] drm: get rid of direct property value access
Date: Wed, 17 Dec 2014 14:37:02 +0100
Message-ID: <20141217133702.GG2711@phenom.ffwll.local>
References: <1418771141-16954-1-git-send-email-robdclark@gmail.com>
 <1418771141-16954-4-git-send-email-robdclark@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173])
 by gabe.freedesktop.org (Postfix) with ESMTP id 212166E7D7
 for <dri-devel@lists.freedesktop.org>; Wed, 17 Dec 2014 05:36:27 -0800 (PST)
Received: by mail-wi0-f173.google.com with SMTP id r20so15771090wiv.0
 for <dri-devel@lists.freedesktop.org>; Wed, 17 Dec 2014 05:36:26 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1418771141-16954-4-git-send-email-robdclark@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gVHVlLCBEZWMgMTYsIDIwMTQgYXQgMDY6MDU6MzFQTSAtMDUwMCwgUm9iIENsYXJrIHdyb3Rl
Ogo+IEZvciBhdG9taWMgZHJpdmVycywgd2Ugd29uJ3QgdXNlIHRoZSB2YWx1ZXMgYXJyYXkgYnV0
IGluc3RlYWQgc2h1bnQKPiB0aGluZ3Mgb2ZmIHRvIG9iai0+YXRvbWljX2dldF9wcm9wZXJ0eSgp
LiAgU28gdG8gc2ltcGxpZnkgdGhpbmdzIG1ha2UKPiBhbGwgcmVhZC93cml0ZSBvZiBwcm9wZXJ0
aWVzIHZhbHVlcyBnbyB0aHJvdWdoIHRoZSBhY2Nlc3NvcnMuCj4gCj4gU2lnbmVkLW9mZi1ieTog
Um9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPgoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0
ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f
Y3J0Yy5jIHwgMTkgKysrKysrKysrKysrKysrLS0tLQo+ICBpbmNsdWRlL2RybS9kcm1fY3J0Yy5o
ICAgICB8ICAzICsrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDQgZGVs
ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jIGIv
ZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiBpbmRleCAyNzgwYTA4Li40ODFiYjI1IDEwMDY0
NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUv
ZHJtL2RybV9jcnRjLmMKPiBAQCAtMjEwNiwxMiArMjEwNiwxNyBAQCBpbnQgZHJtX21vZGVfZ2V0
Y29ubmVjdG9yKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAkJcHJvcF92
YWx1ZXMgPSAodWludDY0X3QgX191c2VyICopKHVuc2lnbmVkIGxvbmcpKG91dF9yZXNwLT5wcm9w
X3ZhbHVlc19wdHIpOwo+ICAJCWZvciAoaSA9IDA7IGkgPCBjb25uZWN0b3ItPnByb3BlcnRpZXMu
Y291bnQ7IGkrKykgewo+ICAJCQlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpwcm9wID0gY29ubmVjdG9y
LT5wcm9wZXJ0aWVzLnByb3BlcnRpZXNbaV07Cj4gKwkJCXVpbnQ2NF90IHZhbDsKPiArCj4gKwkJ
CXJldCA9IGRybV9vYmplY3RfcHJvcGVydHlfZ2V0X3ZhbHVlKCZjb25uZWN0b3ItPmJhc2UsIHBy
b3AsICZ2YWwpOwo+ICsJCQlpZiAocmV0KQo+ICsJCQkJZ290byBvdXQ7Cj4gKwo+ICAJCQlpZiAo
cHV0X3VzZXIocHJvcC0+YmFzZS5pZCwgcHJvcF9wdHIgKyBjb3BpZWQpKSB7Cj4gIAkJCQlyZXQg
PSAtRUZBVUxUOwo+ICAJCQkJZ290byBvdXQ7Cj4gIAkJCX0KPiAtCQkJaWYgKHB1dF91c2VyKGNv
bm5lY3Rvci0+cHJvcGVydGllcy52YWx1ZXNbaV0sCj4gLQkJCQkgICAgIHByb3BfdmFsdWVzICsg
Y29waWVkKSkgewo+ICsJCQlpZiAocHV0X3VzZXIodmFsLCBwcm9wX3ZhbHVlcyArIGNvcGllZCkp
IHsKPiAgCQkJCXJldCA9IC1FRkFVTFQ7Cj4gIAkJCQlnb3RvIG91dDsKPiAgCQkJfQo+IEBAIC00
NDEzLDEyICs0NDE4LDE4IEBAIGludCBkcm1fbW9kZV9vYmpfZ2V0X3Byb3BlcnRpZXNfaW9jdGwo
c3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCQkJCSAgKGFyZy0+cHJvcF92
YWx1ZXNfcHRyKTsKPiAgCQlmb3IgKGkgPSAwOyBpIDwgcHJvcHNfY291bnQ7IGkrKykgewo+ICAJ
CQlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpwcm9wID0gb2JqLT5wcm9wZXJ0aWVzLT5wcm9wZXJ0aWVz
W2ldOwo+ICsJCQl1aW50NjRfdCB2YWw7Cj4gKwo+ICsJCQlyZXQgPSBkcm1fb2JqZWN0X3Byb3Bl
cnR5X2dldF92YWx1ZShvYmosIHByb3AsICZ2YWwpOwo+ICsJCQlpZiAocmV0KQo+ICsJCQkJZ290
byBvdXQ7Cj4gKwo+ICAJCQlpZiAocHV0X3VzZXIocHJvcC0+YmFzZS5pZCwgcHJvcHNfcHRyICsg
Y29waWVkKSkgewo+ICAJCQkJcmV0ID0gLUVGQVVMVDsKPiAgCQkJCWdvdG8gb3V0Owo+ICAJCQl9
Cj4gLQkJCWlmIChwdXRfdXNlcihvYmotPnByb3BlcnRpZXMtPnZhbHVlc1tpXSwKPiAtCQkJCSAg
ICAgcHJvcF92YWx1ZXNfcHRyICsgY29waWVkKSkgewo+ICsKPiArCQkJaWYgKHB1dF91c2VyKHZh
bCwgcHJvcF92YWx1ZXNfcHRyICsgY29waWVkKSkgewo+ICAJCQkJcmV0ID0gLUVGQVVMVDsKPiAg
CQkJCWdvdG8gb3V0Owo+ICAJCQl9Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9jcnRj
LmggYi9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4gaW5kZXggMDI3NThlOC4uNjFhYjNlNSAxMDA2
NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJt
X2NydGMuaAo+IEBAIC03MCw2ICs3MCw5IEBAIHN0cnVjdCBkcm1fb2JqZWN0X3Byb3BlcnRpZXMg
ewo+ICAJICogZGFuZ2xpbmcgcHJvcGVydHkgcG9pbnRlcnM6Cj4gIAkgKi8KPiAgCXN0cnVjdCBk
cm1fcHJvcGVydHkgKnByb3BlcnRpZXNbRFJNX09CSkVDVF9NQVhfUFJPUEVSVFldOwo+ICsJLyog
ZG8gbm90IHJlYWQvd3JpdGUgdmFsdWVzIGRpcmVjdGx5LCBidXQgdXNlIGRybV9vYmplY3RfcHJv
cGVydHlfZ2V0X3ZhbHVlKCkKPiArCSAqIGFuZCBkcm1fb2JqZWN0X3Byb3BlcnR5X3NldF92YWx1
ZSgpOgo+ICsJICovCj4gIAl1aW50NjRfdCB2YWx1ZXNbRFJNX09CSkVDVF9NQVhfUFJPUEVSVFld
Owo+ICB9Owo+ICAKPiAtLSAKPiAyLjEuMAo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUg
RW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDov
L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au
b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2
ZWwK