From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 06/13] drm: add atomic hook to read property plus helper Date: Wed, 17 Dec 2014 15:02:41 +0100 Message-ID: <20141217140241.GJ2711@phenom.ffwll.local> References: <1418771141-16954-1-git-send-email-robdclark@gmail.com> <1418771141-16954-7-git-send-email-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 597946E666 for ; Wed, 17 Dec 2014 06:02:07 -0800 (PST) Received: by mail-wi0-f173.google.com with SMTP id r20so15827122wiv.6 for ; Wed, 17 Dec 2014 06:02:06 -0800 (PST) Content-Disposition: inline In-Reply-To: <1418771141-16954-7-git-send-email-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBEZWMgMTYsIDIwMTQgYXQgMDY6MDU6MzRQTSAtMDUwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IE9uY2UgYSBkcml2ZXIgaXMgdXNpbmcgYXRvbWljIGhlbHBlcnMgZm9yIG1vZGVzZXQsIHRo ZSBuZXh0IHN0ZXAgaXMgdG8KPiBzd2l0Y2ggb3ZlciB0byBhdG9taWMgcHJvcGVydGllcy4gIFRv IGRvIHRoaXMsIHBsdWcgaW4gdGhlIGhlbHBlcgo+IGZ1bmN0aW9uIHRvIHlvdXIgbW9kZWNvbmZp ZyBmdW5jcyBhbmQgYmUgc3VyZSB0byBpbXBsZW1lbnQgdGhlIHBsYW5lLwo+IGNydGMvY29ubmVj dG9yIGF0b21pY197Z2V0LHNldH1fcHJvcGVydHkgdmZ1bmNzIGZvciBhbnkgb2YgeW91ciBtb2Rl LQo+IG9iamVjdHMgd2hpY2ggaGF2ZSBkcml2ZXIgY3VzdG9tIHByb3BlcnRpZXMuCj4gCj4gU2ln bmVkLW9mZi1ieTogUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8IDQ2ICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgICAgICAgICAg fCAgOSArKysrKysrKwo+ICBpbmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oICAgICB8ICAy ICsrCj4gIGluY2x1ZGUvZHJtL2RybV9jcnRjLmggICAgICAgICAgICAgIHwgIDMgKysrCj4gIDQg ZmlsZXMgY2hhbmdlZCwgNjAgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWlj X2hlbHBlci5jCj4gaW5kZXggZDQyZmRiMS4uMWExYWIzNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljX2hlbHBlci5jCj4gQEAgLTE3MDMsNiArMTcwMyw1MiBAQCBiYWNrb2ZmOgo+ICBFWFBP UlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9zZXRfcHJvcGVydHkpOwo+ICAK PiAgLyoqCj4gKyAqIGRybV9hdG9taWNfaGVscGVyX2dldF9wcm9wZXJ0eSAtIGhlbHBlciB0byBy ZWFkIGF0b21pYyBwcm9wZXJ0eQo+ICsgKiBAb2JqOiBkcm0gbW9kZSBvYmplY3Qgd2hvc2UgcHJv cGVydHkgdG8gcmVhZAo+ICsgKiBAcHJvcGVydHk6IHRoZSBwcm9wZXJ0eSB0byByZWFkCj4gKyAq IEB2YWw6IHRoZSByZWFkIHZhbHVlLCByZXR1cm5lZCBieSByZWZlcmVuY2UKPiArICoKPiArICog UkVUVVJOUzoKPiArICogWmVybyBvbiBzdWNjZXNzLCBlcnJvciBjb2RlIG9uIGZhaWx1cmUKPiAr ICovCj4gK2ludCBkcm1fYXRvbWljX2hlbHBlcl9nZXRfcHJvcGVydHkoc3RydWN0IGRybV9tb2Rl X29iamVjdCAqb2JqLAo+ICsJCXN0cnVjdCBkcm1fcHJvcGVydHkgKnByb3BlcnR5LCB1aW50NjRf dCAqdmFsKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gcHJvcGVydHktPmRldjsK PiArCWludCByZXQ7Cj4gKwo+ICsJc3dpdGNoIChvYmotPnR5cGUpIHsKPiArCWNhc2UgRFJNX01P REVfT0JKRUNUX0NPTk5FQ1RPUjogewo+ICsJCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0 b3IgPSBvYmpfdG9fY29ubmVjdG9yKG9iaik7Cj4gKwkJV0FSTl9PTighZHJtX21vZGVzZXRfaXNf bG9ja2VkKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgpKTsKPiArCQlyZXQgPSBj b25uZWN0b3ItPmZ1bmNzLT5hdG9taWNfZ2V0X3Byb3BlcnR5KGNvbm5lY3RvciwKPiArCQkJCWNv bm5lY3Rvci0+c3RhdGUsIHByb3BlcnR5LCB2YWwpOwoKU2hvdWxkbid0IHdlIHVzZSB0aGUgZ2V0 IGhlbHBlcnMgaW50cm9kdWNlZCBpbiBwcmV2aW91cyBwYXRjaGVzIGhlcmU/IEZvcgpsZWdhY3kg c3VwcG9ydCB3ZSBkZWZpbml0ZWx5IHdhbnQgb2xkIGNvcmUgc3R1ZmYgbGlrZSBkcG1zIHRvIGtl ZXAKd29ya2luZy4gT2YgY291cnNlIHRoYXQgbWVhbnMgYWxsIHRoZSBuZXcgYXRvbWljIHByb3Bl cnRpZXMgd29uJ3QgZ2V0Cm1hZ2ljYWxseSBmaWx0ZXJlZCBvdXQuIEJ1dCBJIHRoaW5rIHdlIG5l ZWQgdG8gaGlkZSB0aGVtIGV4cGxpY2l0bHkKYW55d2F5LCBlLmcuIHdpdGggYSBuZXcgRFJNX01P REVfUFJPUF9BVE9NSUMgYW5kIGNoZWNraW5nIGZvciB0aGF0IGluCmxlZ2FjeSBwYXRocy4KLURh bmllbAoKPiArCQlicmVhazsKPiArCX0KPiArCWNhc2UgRFJNX01PREVfT0JKRUNUX0NSVEM6IHsK PiArCQlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBvYmpfdG9fY3J0YyhvYmopOwo+ICsJCVdBUk5f T04oIWRybV9tb2Rlc2V0X2lzX2xvY2tlZCgmY3J0Yy0+bXV0ZXgpKTsKPiArCQlyZXQgPSBjcnRj LT5mdW5jcy0+YXRvbWljX2dldF9wcm9wZXJ0eShjcnRjLAo+ICsJCQkJY3J0Yy0+c3RhdGUsIHBy b3BlcnR5LCB2YWwpOwo+ICsJCWJyZWFrOwo+ICsJfQo+ICsJY2FzZSBEUk1fTU9ERV9PQkpFQ1Rf UExBTkU6IHsKPiArCQlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSA9IG9ial90b19wbGFuZShvYmop Owo+ICsJCVdBUk5fT04oIWRybV9tb2Rlc2V0X2lzX2xvY2tlZCgmcGxhbmUtPm11dGV4KSk7Cj4g KwkJcmV0ID0gcGxhbmUtPmZ1bmNzLT5hdG9taWNfZ2V0X3Byb3BlcnR5KHBsYW5lLAo+ICsJCQkJ cGxhbmUtPnN0YXRlLCBwcm9wZXJ0eSwgdmFsKTsKPiArCQlicmVhazsKPiArCX0KPiArCWRlZmF1 bHQ6Cj4gKwkJcmV0ID0gLUVJTlZBTDsKPiArCQlicmVhazsKPiArCX0KPiArCj4gKwlyZXR1cm4g cmV0Owo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJfZ2V0X3Byb3BlcnR5 KTsKPiArCj4gKy8qKgo+ICAgKiBkcm1fYXRvbWljX2hlbHBlcl9wYWdlX2ZsaXAgLSBleGVjdXRl IGEgbGVnYWN5IHBhZ2UgZmxpcAo+ICAgKiBAY3J0YzogRFJNIGNydGMKPiAgICogQGZiOiBEUk0g ZnJhbWVidWZmZXIKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+IGluZGV4IDQ4MWJiMjUuLjU3Y2Q5NTAgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX2NydGMuYwo+IEBAIC0zODc4LDggKzM4NzgsMTcgQEAgRVhQT1JUX1NZTUJPTChkcm1f b2JqZWN0X3Byb3BlcnR5X3NldF92YWx1ZSk7Cj4gIGludCBkcm1fb2JqZWN0X3Byb3BlcnR5X2dl dF92YWx1ZShzdHJ1Y3QgZHJtX21vZGVfb2JqZWN0ICpvYmosCj4gIAkJCQkgIHN0cnVjdCBkcm1f cHJvcGVydHkgKnByb3BlcnR5LCB1aW50NjRfdCAqdmFsKQo+ICB7Cj4gKwlzdHJ1Y3QgZHJtX21v ZGVfY29uZmlnICpjb25maWcgPSAmcHJvcGVydHktPmRldi0+bW9kZV9jb25maWc7Cj4gIAlpbnQg aTsKPiAgCj4gKwkvKiByZWFkLW9ubHkgcHJvcGVydGllcyBieXBhc3MgYXRvbWljIG1lY2hhbmlz bSBhbmQgc3RpbGwgc3RvcmUKPiArCSAqIHRoZWlyIHZhbHVlIGluIG9iai0+cHJvcGVydGllcy0+ dmFsdWVzW10uLiBtb3N0bHkgdG8gYXZvaWQKPiArCSAqIGhhdmluZyB0byBkZWFsIHcvIEVESUQg YW5kIHNpbWlsYXIgcHJvcHMgaW4gYXRvbWljIHBhdGhzOgo+ICsJICovCj4gKwlpZiAoY29uZmln LT5mdW5jcy0+YXRvbWljX2dldF9wcm9wZXJ0eSAmJgo+ICsJCQkhKHByb3BlcnR5LT5mbGFncyAm IERSTV9NT0RFX1BST1BfSU1NVVRBQkxFKSkKPiArCQlyZXR1cm4gY29uZmlnLT5mdW5jcy0+YXRv bWljX2dldF9wcm9wZXJ0eShvYmosIHByb3BlcnR5LCB2YWwpOwo+ICsKPiAgCWZvciAoaSA9IDA7 IGkgPCBvYmotPnByb3BlcnRpZXMtPmNvdW50OyBpKyspIHsKPiAgCQlpZiAob2JqLT5wcm9wZXJ0 aWVzLT5wcm9wZXJ0aWVzW2ldID09IHByb3BlcnR5KSB7Cj4gIAkJCSp2YWwgPSBvYmotPnByb3Bl cnRpZXMtPnZhbHVlc1tpXTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2F0b21pY19o ZWxwZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmgKPiBpbmRleCBmOTU2YjQx Li41ZTcyYjgyIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmgK PiArKysgYi9pbmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oCj4gQEAgLTc0LDYgKzc0LDgg QEAgaW50IGRybV9hdG9taWNfaGVscGVyX3BsYW5lX3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX3Bs YW5lICpwbGFuZSwKPiAgaW50IGRybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9zZXRfcHJvcGVy dHkoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCQkJCQlzdHJ1Y3QgZHJtX3By b3BlcnR5ICpwcm9wZXJ0eSwKPiAgCQkJCQl1aW50NjRfdCB2YWwpOwo+ICtpbnQgZHJtX2F0b21p Y19oZWxwZXJfZ2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1fbW9kZV9vYmplY3QgKm9iaiwKPiArCQkJ ICAgc3RydWN0IGRybV9wcm9wZXJ0eSAqcHJvcGVydHksIHVpbnQ2NF90ICp2YWwpOwo+ICBpbnQg ZHJtX2F0b21pY19oZWxwZXJfcGFnZV9mbGlwKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCQkJ CXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICAJCQkJc3RydWN0IGRybV9wZW5kaW5nX3Zi bGFua19ldmVudCAqZXZlbnQsCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9jcnRjLmgg Yi9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4gaW5kZXggZTZjZmRhZi4uY2E4YmE3MiAxMDA2NDQK PiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2Ny dGMuaAo+IEBAIC05NDEsNiArOTQxLDcgQEAgc3RydWN0IGRybV9tb2RlX3NldCB7Cj4gICAqIHN0 cnVjdCBkcm1fbW9kZV9jb25maWdfZnVuY3MgLSBiYXNpYyBkcml2ZXIgcHJvdmlkZWQgbW9kZSBz ZXR0aW5nIGZ1bmN0aW9ucwo+ICAgKiBAZmJfY3JlYXRlOiBjcmVhdGUgYSBuZXcgZnJhbWVidWZm ZXIgb2JqZWN0Cj4gICAqIEBvdXRwdXRfcG9sbF9jaGFuZ2VkOiBmdW5jdGlvbiB0byBoYW5kbGUg b3V0cHV0IGNvbmZpZ3VyYXRpb24gY2hhbmdlcwo+ICsgKiBAYXRvbWljX2dldF9wcm9wZXJ0eTog YXRvbWljIHdheSB0byByZWFkIHByb3BlcnR5IHZhbHVlCj4gICAqIEBhdG9taWNfY2hlY2s6IGNo ZWNrIHdoZXRoZXIgYSBnaXZlIGF0b21pYyBzdGF0ZSB1cGRhdGUgaXMgcG9zc2libGUKPiAgICog QGF0b21pY19jb21taXQ6IGNvbW1pdCBhbiBhdG9taWMgc3RhdGUgdXBkYXRlIHByZXZpb3VzbHkg dmVyaWZpZWQgd2l0aAo+ICAgKiAJYXRvbWljX2NoZWNrKCkKPiBAQCAtOTU0LDYgKzk1NSw4IEBA IHN0cnVjdCBkcm1fbW9kZV9jb25maWdfZnVuY3Mgewo+ICAJCQkJCSAgICAgc3RydWN0IGRybV9t b2RlX2ZiX2NtZDIgKm1vZGVfY21kKTsKPiAgCXZvaWQgKCpvdXRwdXRfcG9sbF9jaGFuZ2VkKShz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgCj4gKwlpbnQgKCphdG9taWNfZ2V0X3Byb3BlcnR5 KShzdHJ1Y3QgZHJtX21vZGVfb2JqZWN0ICpvYmosCj4gKwkJCQlzdHJ1Y3QgZHJtX3Byb3BlcnR5 ICpwcm9wZXJ0eSwgdWludDY0X3QgKnZhbCk7Cj4gIAlpbnQgKCphdG9taWNfY2hlY2spKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCSAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqYSk7 Cj4gIAlpbnQgKCphdG9taWNfY29tbWl0KShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+IC0tIAo+ IDIuMS4wCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y cG9yYXRpb24KKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=