Re: [PATCH 4/4] drm/i915: Subsume intel_ctx_submit_request in to drm_i915_gem_request

[Daniel Vetter <daniel@ffwll.ch>]

On Wed, Dec 17, 2014 at 09:39:46PM +0100, Daniel Vetter wrote:
> On Tue, Dec 16, 2014 at 12:32:30PM +0000, Nick Hoath wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index d68c75f..114adc3 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2036,6 +2036,30 @@ struct drm_i915_gem_request {
> >  	struct list_head client_list;
> >  
> >  	uint32_t uniq;
> > +
> > +	/**
> > +	 * The ELSP only accepts two elements at a time, so we queue
> > +	 * context/tail pairs on a given queue (ring->execlist_queue) until the
> > +	 * hardware is available. The queue serves a double purpose: we also use
> > +	 * it to keep track of the up to 2 contexts currently in the hardware
> > +	 * (usually one in execution and the other queued up by the GPU): We
> > +	 * only remove elements from the head
> > +	 * of the queue when the hardware informs us that an element has been
> > +	 * completed.
> > +	 *
> > +	 * All accesses to the queue are mediated by a spinlock
> > +	 * (ring->execlist_lock).
> > +	 */
> > +
> > +	/** Execlist link in the submission queue.*/
> > +	struct list_head execlist_link;
> > +
> > +	/** Execlists workqueue for processing this request in a bottom half */
> > +	struct work_struct work;
> 
> Hm I've thought this would drop out with the other rework we've had
> floating around. It's also not used anywhere, so I guess it disappeared
> for real and is just a leftover from rebasing?

And a plea from your maintainer: I've asked for exactly this in my reply,
but there was no reply from you nor any mention about anything in the
in-patch changelog. So I had to digg through all the patches and the old
thread to figure out again what it is my subconscious told me is missing.

This isn't efficient, so please always acknowledge review feedbacka and
questions either with a reply or in the commit message changelogs (there
it needs the name of the reviewer in case there was lots of feedback.)

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx