From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH] tools: libxl: link libxlu against libxl.
Date: Wed, 17 Dec 2014 15:54:55 -0500
Message-ID: <20141217205455.GB1829@laptop.dumpdata.com>
References: <321a64dc64db335460b51becfc040f4cb0e84a9e.1407146305.git.ian.campbell@citrix.com>
	<1418637751.16425.64.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1418637751.16425.64.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Bastian Blank <waldi@debian.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, Dec 15, 2014 at 10:02:31AM +0000, Ian Campbell wrote:
> On Mon, 2014-08-04 at 10:58 +0100, Ian Campbell wrote:
> 
> Ping again. This issue has resurfaced in the Debian packaging of the 4.5
> rcs. I think we should fix this for 4.5, the risks are minimal.

Ah, the patch did not have 'for-xen-4.5' in it :-P

> 
> > It uses libxl_defbool_set and must therefore be linked against the
> > right library.
> > 
> > Spotted by dpkg-shlibdeps and pointed out by Bastian Blank:
> > 
> > dpkg-shlibdeps: warning: symbol libxl_defbool_set used by debian/libxen-4.4/usr/lib/libxlutil-4.4.so found in none of the libraries
> > 
> > This required switching the make rule from $^ to an explicit
> > LIBXLU_OBJS since the former now includes libxenlight.so.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Bastian Blank <waldi@debian.org>

Shouldn't this be 'Reported-by: "

Anyhow,

Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > ---
> >  tools/libxl/Makefile |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> > index bd0db3b..e61048d 100644
> > --- a/tools/libxl/Makefile
> > +++ b/tools/libxl/Makefile
> > @@ -35,7 +35,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
> >  LIBXL_LIBS += $(PTHREAD_LIBS)
> >  LIBXL_LIBS += $(LIBXL_LIBS-y)
> >  
> > -LIBXLU_LIBS =
> > +LIBXLU_LIBS = libxenlight.so
> >  
> >  LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
> >  ifeq ($(LIBXL_BLKTAP),y)
> > @@ -213,8 +213,8 @@ libxlutil.so: libxlutil.so.$(XLUMAJOR)
> >  libxlutil.so.$(XLUMAJOR): libxlutil.so.$(XLUMAJOR).$(XLUMINOR)
> >  	$(SYMLINK_SHLIB) $< $@
> >  
> > -libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS)
> > -	$(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
> > +libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS) libxenlight.so
> > +	$(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $(LIBXLU_OBJS) $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
> >  
> >  libxlutil.a: $(LIBXLU_OBJS)
> >  	$(AR) rcs libxlutil.a $^
> 
>