All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Otubo <eduardo.otubo@profitbricks.com>
To: Paul Moore <pmoore@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] seccomp: add mbind() to the syscall whitelist
Date: Thu, 18 Dec 2014 09:27:04 +0100	[thread overview]
Message-ID: <20141218082704.GA7488@vader> (raw)
In-Reply-To: <20141217205009.28322.63696.stgit@localhost>

On Wed, Dec 17, 2014 at 03:50:09PM -0500, Paul Moore wrote:
> The "memory-backend-ram" QOM object utilizes the mbind(2) syscall to
> set the policy for a memory range.  Add the syscall to the seccomp
> sandbox whitelist.
> 
> Signed-off-by: Paul Moore <pmoore@redhat.com>
> ---
>  qemu-seccomp.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index af6a375..b0c6269 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -235,7 +235,8 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
>      { SCMP_SYS(fallocate), 240 },
>      { SCMP_SYS(fadvise64), 240 },
>      { SCMP_SYS(inotify_init1), 240 },
> -    { SCMP_SYS(inotify_add_watch), 240 }
> +    { SCMP_SYS(inotify_add_watch), 240 },
> +    { SCMP_SYS(mbind), 240 }
>  };
>  
>  int seccomp_start(void)
> 

Acked-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>

I have a minor fix already in plan, so I'll do a pull request tomorrow
by the end of the day.

Thanks for the patch.

-- 
Eduardo Otubo
ProfitBricks GmbH

      parent reply	other threads:[~2014-12-18  8:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17 20:50 [Qemu-devel] [PATCH] seccomp: add mbind() to the syscall whitelist Paul Moore
2014-12-17 23:51 ` Eduardo Habkost
2014-12-18  8:27 ` Eduardo Otubo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141218082704.GA7488@vader \
    --to=eduardo.otubo@profitbricks.com \
    --cc=pbonzini@redhat.com \
    --cc=pmoore@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.