From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Regarding patch: http://patchwork.ozlabs.org/patch/373593/
Date: Thu, 18 Dec 2014 12:16:06 +0100 [thread overview]
Message-ID: <201412181216.06913.marex@denx.de> (raw)
In-Reply-To: <BL2PR03MB161DE5448D4F4B4C8635AB6E06A0@BL2PR03MB161.namprd03.prod.outlook.com>
On Thursday, December 18, 2014 at 09:32:56 AM, Ramneek Mehresh wrote:
> Hi Marex,
>
> Following u-boot patch is pending for your review for some time. Please let
> me know if you have any concerns. fsl/usb: Add USB XHCI support:
> http://patchwork.ozlabs.org/patch/373593/
I missed the patch completely, sorry. Next time, please keep me on CC when
submitting the patches, that helps a lot.
As for the board_usb_init, you can drop the inline and the __board_usb_init()
and do:
__weak int board_usb_init(int index, enum usb_init_type init)
{
return 0;
}
The static void fsl_xhci_core_exit(struct fsl_xhci *fsl_xhci) must shut down
the controller, which I don't see happening. Why?
Thanks!
Best regards,
Marek Vasut
next parent reply other threads:[~2014-12-18 11:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BL2PR03MB161DE5448D4F4B4C8635AB6E06A0@BL2PR03MB161.namprd03.prod.outlook.com>
2014-12-18 11:16 ` Marek Vasut [this message]
2015-01-12 5:26 ` [U-Boot] Regarding patch: http://patchwork.ozlabs.org/patch/373593/ Ramneek Mehresh
2015-01-12 14:29 ` Marek Vasut
2015-04-06 8:58 ` Ramneek Mehresh
2015-04-06 15:11 ` Marek Vasut
2015-04-07 6:18 ` Ramneek Mehresh
2015-04-07 13:51 ` Marek Vasut
2015-04-07 14:05 ` Ramneek Mehresh
2015-04-07 14:13 ` Marek Vasut
2015-04-07 14:42 ` Ramneek Mehresh
2015-04-07 18:55 ` Marek Vasut
2015-04-07 14:52 ` Ramneek Mehresh
2015-04-07 18:55 ` Marek Vasut
2015-04-07 6:39 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412181216.06913.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.