From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Vandana Kannan <vandana.kannan@intel.com>,
intel-gfx@lists.freedesktop.org, paulo.r.zanoni@intel.com,
rodrigo.vivi@intel.com
Subject: Re: [PATCH 1/7] drm/i915: Modifying structures related to DRRS
Date: Thu, 18 Dec 2014 21:13:15 +0100 [thread overview]
Message-ID: <20141218201315.GO2711@phenom.ffwll.local> (raw)
In-Reply-To: <20141218162924.GK32100@nuc-i3427.alporthouse.com>
On Thu, Dec 18, 2014 at 04:29:24PM +0000, Chris Wilson wrote:
> On Thu, Dec 18, 2014 at 09:02:15PM +0530, Vandana Kannan wrote:
> > Earlier, DRRS structures were specific to eDP (used only in intel_dp).
> > Since DRRS can be extended to other internal display types
> > (if the panel supports multiple RR), modifying structures
> > to be part of drm_i915_private and have a provision to add display related
> > structs like intel_dp.
>
> What's the justification for drm_i915_private though? Why not extend the
> struct intel_panel? I think it is conceptually cleaner if PSR was part
> of the common panel logic rather than bolted onto the side of
> drm_i915_private - on such systems there is still likely to only be
> struct intel_panel attached to the connectors on the system.
Looking up intel_panel from both gem and modeset contexts is painful, so
imo putting it into i915_private is the right approach. We use the same
design with psr and probably soonish with fbc (when it's using the
frontbuffer tracking code).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-18 20:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 15:32 [PATCH v2 0/8] eDP DRRS based on frontbuffer tracking Vandana Kannan
2014-12-18 15:32 ` [PATCH 1/7] drm/i915: Modifying structures related to DRRS Vandana Kannan
2014-12-18 16:29 ` Chris Wilson
2014-12-18 20:13 ` Daniel Vetter [this message]
2014-12-18 15:32 ` [PATCH 2/7] drm/i915: Initialize DRRS delayed work Vandana Kannan
2014-12-18 15:32 ` [PATCH 3/7] drm/i915: Enable/disable DRRS Vandana Kannan
2014-12-18 15:32 ` [PATCH 4/7] drm/i915: DRRS calls based on frontbuffer Vandana Kannan
2014-12-18 20:15 ` Daniel Vetter
2014-12-18 15:32 ` [PATCH 5/7] drm/i915/bdw: Add support for DRRS to switch RR Vandana Kannan
2014-12-18 15:32 ` [PATCH 6/7] drm/i915: Support for RR switching on VLV Vandana Kannan
2014-12-18 15:32 ` [PATCH 7/7] drm/i915: Enable eDP DRRS for CHV Vandana Kannan
2014-12-19 9:42 ` shuang.he
2014-12-18 20:15 ` [PATCH v2 0/8] eDP DRRS based on frontbuffer tracking Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218201315.GO2711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=vandana.kannan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.