All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Alan Tull <atull@opensource.altera.com>
Cc: kbuild-all@01.org, Michal Simek <monstr@monstr.eu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: fpga manager: fix odd_ptr_err.cocci warnings
Date: Fri, 19 Dec 2014 17:45:27 +0800	[thread overview]
Message-ID: <20141219094527.GA99450@athens> (raw)
In-Reply-To: <201412191721.MzCPy2f4%fengguang.wu@intel.com>

drivers/staging/fpga/socfpga.c:647:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 648

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Alan Tull <atull@opensource.altera.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 socfpga.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/fpga/socfpga.c
+++ b/drivers/staging/fpga/socfpga.c
@@ -645,7 +645,7 @@ static int socfpga_fpga_probe(struct pla
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
 	priv->fpga_data_addr = devm_ioremap_resource(dev, res);
 	if (IS_ERR(priv->fpga_data_addr))
-		return PTR_ERR(priv->fpga_base_addr);
+		return PTR_ERR(priv->fpga_data_addr);
 
 	priv->irq = platform_get_irq(pdev, 0);
 	if (priv->irq < 0)

           reply	other threads:[~2014-12-19  9:46 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <201412191721.MzCPy2f4%fengguang.wu@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141219094527.GA99450@athens \
    --to=fengguang.wu@intel.com \
    --cc=atull@opensource.altera.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monstr@monstr.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.